1641707 - reviewers group for addons

Status: RESOLVED FIXED

(Conduit :: Administration, task, P3)

Description

[Shane Caraveo (:mixedpuppy)]

I'd like to have extension-reviewers group created that will block review on some directories, be optional on others.

extension-reviewers

owners/peers in:

• https://wiki.mozilla.org/Modules/Toolkit#Webextensions
• https://wiki.mozilla.org/Modules/Desktop_Firefox#Add-ons_Manager
• https://wiki.mozilla.org/Modules/Desktop_Firefox#Add-ons_Manager_UI
• except Jim Mathies

blocking on:

• browser/components/extensions
• toolkit/components/extensions
• toolkit/mozapps/extensions

optional on:

• mobile/android/components/extensions/

Comment 1

[David Lawrence [:dkl]]

Project:
https://phabricator.services.mozilla.com/project/profile/130/

Herald:
https://phabricator.services.mozilla.com/H246
https://phabricator.services.mozilla.com/H247

Comment 2

[Shane Caraveo (:mixedpuppy)]

Question on reviewer group behavior.

We want the notification that we should look at patches, and to require a review. However, in many cases that "review" may be simply decided we don't need to be involved, and we want to remove the reviewer group. Right now this doesn't seem possible, the group gets added back immediately. Is there any way to address that?

Comment 3

[Shane Caraveo (:mixedpuppy)]

To clarify, we want to be able to remove it, but we might not want non-members to be able to remove it.

Comment 4

[Shane Caraveo (:mixedpuppy)]

BTW, given the experience with this in the last 24hrs, I'm wondering if what we really want is an owner package.

https://secure.phabricator.com/book/phabricator/article/owners/

But essentially, we'd like to be able to drop the review requirement if we deem it isn't necessary (no-readd?). If possible, an ability on an individual basis to turn off (unsubscribe?) notifications via email. If one of us (owners) reviews, to drop the package/group from the reviewers.

Comment 5

[:glob ✱]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)

BTW, given the experience with this in the last 24hrs, I'm wondering if what we really want is an owner package.

https://secure.phabricator.com/book/phabricator/article/owners/

We're investigating the viability of the owners feature; however, what we currently do with herald rules is a superset of the features provided by 'owners':

The intent of this feature is to make it easy to configure simple, reasonable behaviors. If you want more tailored or specific triggers, you can write more powerful rules by using Herald.

Comment 6

[Shane Caraveo (:mixedpuppy)]

Can we get something a little closer to https://phabricator.services.mozilla.com/H251 ?

The goal is to get the review group one only once, only when a group review is not already involved, limit phab notifications as little as possible, allow any group reviewer to remove the group and not have it come back later for any reason (it still does under some circumstances).

Comment 7

[David Lawrence [:dkl]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #6)

Can we get something a little closer to https://phabricator.services.mozilla.com/H251 ?

The goal is to get the review group one only once, only when a group review is not already involved, limit phab notifications as little as possible, allow any group reviewer to remove the group and not have it come back later for any reason (it still does under some circumstances).

Done