1641728 - When extension is not found, the delegate handler never rejects the javascript side

Status: REOPENED

(GeckoView :: Extensions, task, P3)

Description

[[ex-Mozilla] Agi Sferro | :agi]

In this code https://searchfox.org/mozilla-central/rev/9aa7bebfd169bc2ead00ef596498a406e56bbb85/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebExtensionController.java#862 if extensionFromBundle cannot find the extension (e.g. if the extension was installed by Gecko) we never reject the callback so the javascript side holds onto the promise indefinitely. We should just fail the callback when that happens.

Comment 1

[Chris Peterson [:cpeterson]]

Moving some extension bugs to the GeckoView::Extensions component.

Comment 2

[Chris Peterson [:cpeterson]]

Tasks should have severity N/A.

Comment 3

[Polly McEldowney [:pollymce]]

This code doesn't look the same any more - so closing out as no longer relevant.
If still a problem, please open an issue with an up to date explanation.

Comment 4

[Rob Wu [:robwu]]

The code looks pretty much the same to me: https://searchfox.org/mozilla-central/rev/ab488b411ff15c2e11dbd4d6be0455bb64bc8fc1/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/WebExtensionController.java#1092-1094

Comment 5

[Olivia Hall [:olivia]]

Thanks, :robwu! The Android team is trying to clean up our good-first-bugs and this was closed during triage. Do you have context on this bug?