1641739 - Reduce the support child list types for flex / grid container's frame list manipulation methods

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

This is a follow-up on mats' review comment https://phabricator.services.mozilla.com/D77204?id=286541#inline-447073

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1641739 - Reduce the support child list types for flex / grid container's frame list manipulation methods.

These flex / grid's methods are implemented by delegating to
nsContainerFrame's methods. We shouldn't assume they can support more
child list types than the ones supported in nsContainerFrame's methods.

• NoteNewChildren is a helper for flex and grid's AppendFrame and
  InsertFrames, and nsContainerFrame::{AppendFrame,InsertFrames} supports
  only kPrincipalList and kNoReflowPrincipalList.

• nsContainerFrame::RemoveFrame supports only kPrincipalList and
  kNoReflowPrincipalList.

• nsContainerFrame::SetInitialChildList supports only kPrincipalList and
  kBackdropList.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1933024a9cbf
Reduce the support child list types for flex / grid container's frame list manipulation methods. r=mats

Comment 3

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1933024a9cbf