1641961 - jstest harness: shell-option() works in jstests.list but not in |reftest| lines, for wonderful reason

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Jason Orendorff [:jorendorff]]

To reproduce, make a file under js/src/tests/non262 that contains

// |reftest| shell-option(--enable-weak-refs)

reportCompare(0, 0, 'ok');

The super helpful error message is

Error: can't open : No such file or directory

This is because the command line being sent to the JS engine starts with $OBJDIR/dist/bin/js ''; note the empty argument.

This in turn is because -- in a |reftest| line is treated as the start of a comment, so what the option-parser sees is

// |reftest| shell-option(

Comment 1

[Jason Orendorff [:jorendorff]]

Possible culprit: https://searchfox.org/mozilla-central/source/js/src/tests/lib/manifest.py#361-362

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

This change from Andre seems to fix it:

https://hg.mozilla.org/try/diff/54da1cfd316816d86dd975348b6f2dcb9b077284/js/src/tests/lib/manifest.py

Having said that, I am not entirely sure what's going on here yet -- mostly because I'm slow at reading a regexp of that size and complexity!

Comment 3

[André Bargull [:anba]]

The modified expression adds a negative look-behind before --, so that the comment part is no longer matched for (--.

Comment 4

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1641961 - Don't parse shell option as comment in shell directive line r?anba!,jorendorff!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a99486af033
Don't parse shell option as comment in shell directive line r=anba,jorendorff

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9a99486af033