`-p all` try syntax selects shippable builds instead of opt
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox79 fixed)
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: bhearsum, Assigned: bhearsum)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ci-costs-2020:done])
Attachments
(1 file, 1 obsolete file)
Eg: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1407c030df4f9ea43cb103ffddeac8234e9c2eb
It doesn't happen for a single platform, eg: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9fa84bad3c2b047c4030263ab79dd9b28f0d2181
This is a follow up from bug 1638014.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
Comment 2•4 years ago
|
||
Not sure if I should file a new bug, but relatedly, pushing -p macosx64 -b o
creates both an opt and a shippable.
Assignee | ||
Comment 3•4 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2)
Not sure if I should file a new bug, but relatedly, pushing
-p macosx64 -b o
creates both an opt and a shippable.
I'll take that as a follow-up here.
Assignee | ||
Comment 4•4 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #2)
Not sure if I should file a new bug, but relatedly, pushing
-p macosx64 -b o
creates both an opt and a shippable.
So, shippable
gets created because -t
defaults to all
, which includes a bunch of perf tests - so that's expected (or at least explainable).
I'm actually not certain why the opt build is there, as there's nothing downstream of it. It's possible this is because of https://bugzilla.mozilla.org/show_bug.cgi?id=1641058, but I don't think so. Going to keep digging on this.
Assignee | ||
Comment 5•4 years ago
|
||
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #4)
I'm actually not certain why the opt build is there, as there's nothing downstream of it. It's possible this is because of https://bugzilla.mozilla.org/show_bug.cgi?id=1641058, but I don't think so. Going to keep digging on this.
Alright, so this boils down to the fact that opt
now refers to two different build types, and try syntax doesn't distinguish between them (https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/try_option_syntax.py#19). We end up returning at https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/taskcluster/taskgraph/try_option_syntax.py#651 for this case.
One possible fix would be to add a new build type alias (s
for shippable). This would let us distinguish between them, and also has the advantage of the current developer behaviour using the faster opt builds (shippable builds would still be used when perf tests are selected, of course).
Comment 6•4 years ago
|
||
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #4)
(In reply to Mike Hommey [:glandium] from comment #2)
Not sure if I should file a new bug, but relatedly, pushing
-p macosx64 -b o
creates both an opt and a shippable.So,
shippable
gets created because-t
defaults toall
, which includes a bunch of perf tests - so that's expected (or at least explainable).
I always use "-t none".
Assignee | ||
Comment 7•4 years ago
|
||
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #5)
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #4)
I'm actually not certain why the opt build is there, as there's nothing downstream of it. It's possible this is because of https://bugzilla.mozilla.org/show_bug.cgi?id=1641058, but I don't think so. Going to keep digging on this.
Alright, so this boils down to the fact that
opt
now refers to two different build types, and try syntax doesn't distinguish between them (https://searchfox.org/mozilla-central/source/taskcluster/taskgraph/try_option_syntax.py#19). We end up returning at https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/taskcluster/taskgraph/try_option_syntax.py#651 for this case.One possible fix would be to add a new build type alias (
s
for shippable). This would let us distinguish between them, and also has the advantage of the current developer behaviour using the faster opt builds (shippable builds would still be used when perf tests are selected, of course).
After some further debugging I'm moving this out to https://bugzilla.mozilla.org/show_bug.cgi?id=1645265
(In reply to Mike Hommey [:glandium] from comment #6)
(In reply to bhearsum@mozilla.com (:bhearsum) from comment #4)
(In reply to Mike Hommey [:glandium] from comment #2)
Not sure if I should file a new bug, but relatedly, pushing
-p macosx64 -b o
creates both an opt and a shippable.So,
shippable
gets created because-t
defaults toall
, which includes a bunch of perf tests - so that's expected (or at least explainable).I always use "-t none".
Ah, I missed that. I think my analysis above was incomplete in any case -- my fix in the new bug should address it regardless of test/talos/raptor flags passed.
Comment 9•4 years ago
|
||
bugherder |
Comment 10•4 years ago
•
|
||
So... macosx shippable is still happening... and worse, the opt builds aren't. See e.g. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a625799f5b9ca55d1dd77378a965b869f0ac58e (this is an old link because I forgot to submit this comment, but this is still happening, but I need to trigger the missing builds, so by the time you look, they will appear as if they had happened)
Assignee | ||
Comment 11•4 years ago
|
||
Assignee | ||
Comment 12•4 years ago
|
||
(In reply to Mike Hommey [:glandium] from comment #10)
So... macosx shippable is still happening... and worse, the opt builds aren't. See e.g. https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a625799f5b9ca55d1dd77378a965b869f0ac58e (this is an old link because I forgot to submit this comment, but this is still happening, but I need to trigger the missing builds, so by the time you look, they will appear as if they had happened)
https://phabricator.services.mozilla.com/D81182 is kindof a fix for this, but I'm not sure I want to land it. More details in phabricator.
Updated•4 years ago
|
Assignee | ||
Comment 13•4 years ago
|
||
I realize there's still an issue with try syntax here, but fixing it is something I probably can't prioritize for awhile, especially given the relatively low syntax usage vs. chooser/auto/fuzzy (https://gist.github.com/ahal/ebfc230994799517166fc32a04da8884).
Updated•4 years ago
|
Description
•