Closed Bug 1642082 Opened 4 years ago Closed 4 years ago

Regression: Top Sites area on New Tab Page is no longer collapsable

Categories

(Firefox :: New Tab Page, defect)

defect
Points:
1

Tracking

()

VERIFIED FIXED
Firefox 79
Iteration:
79.1 - June 1 - June 14
Tracking Status
firefox-esr68 --- unaffected
firefox76 --- unaffected
firefox77 --- unaffected
firefox78 + verified
firefox79 --- verified

People

(Reporter: mehmet.sahin, Assigned: bugzilla)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Nightly 78.0a1 (2020-05-29) (64-Bit)
macOS 10.15.5

STR:

1.) Enable Top Sites on your NTP
2.) Open a NTP
3.) Click on the Top Sites icon / Triangle above the Top Sites

Expected: Top Sites area should collapse.
Actual: Top Sites area does not collapse.

This is a recent regression.

Has Regression Range: --- → yes

[Tracking Requested - why for this release]:
Easy-to-fix but annoying regression resulting from a 77 patch: bug 1634279.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 79.1 - June 1 - June 14
Points: --- → 1

[Tracking Requested - why for this release]:
Sorry, I meant 78 :)

Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a9abdda8e7f7
Restore the ability to collapse the NTP Top Sites section. r=thecount

Just a question: I haven't mentioned that in my bugreport, but when you click on the triangle to try to collapse the Top Sites sections, the collapse does not work AND the tiles are no longer clickable. Will the "not clickable" issue also be fixed with your patch?

Yes, my patch should fix that issue.

(In reply to Harry Twyford [:harry] from comment #7)

Yes, my patch should fix that issue.

Thanks for your feedback :)

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

The patch landed in nightly and beta is affected.
:harry, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(htwyford)

Comment on attachment 9153141 [details]
Bug 1642082 - Restore the ability to collapse the NTP Top Sites section. r?thecount!

Beta/Release Uplift Approval Request

  • User impact if declined: Regression where the Top Sites section on the NTP can't be collapsed.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Very small (2-line) change that's baked on Nightly for a few days and that only affects the front-end. If something goes wrong with this patch, it would be easy to undo.
  • String changes made/needed:
Flags: needinfo?(htwyford)
Attachment #9153141 - Flags: approval-mozilla-beta?

Comment on attachment 9153141 [details]
Bug 1642082 - Restore the ability to collapse the NTP Top Sites section. r?thecount!

regression fix for new tab, approved for 78.0b3

Attachment #9153141 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I have verified the following, using Firefox Beta 78.0b3 (Build ID: 20200604213430), and Firefox Nightly 79.0a1 (Build ID: 20200605043926) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 18.04:

  • The "Top Sites" section is collapsed when the title is clicked.
  • The "Top Sites" section is expanded when the title is clicked again.
  • The "Top Sites" section is collapsed when the "Collapse Section" option is selected from the "Section Context Menu" (...).
  • The "Top Sites" section is expanded when the "Expand Section" option is selected from the "Section Context Menu" (...).
  • The "Top Sites" tiles can be clicked after the "Top Sites" section is expanded.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: