Closed Bug 1642140 Opened 5 months ago Closed 5 months ago

Stop overprioritizing image preload

Categories

(Core :: ImageLib, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 file)

I found out that we:

  • don't always set LOAD_BACKGROUND (a must) for link-preloaded images
  • prioritization of image link preloads is exaggerated (and also at a wrong spot)
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Summary: Deprioritize image preload more properly → Stop overprioritizing image preload
Pushed by honzab.moz@firemni.cz:
https://hg.mozilla.org/integration/autoland/rev/3a863c2bc348
Image link-preloads: do not overprioritize, never set UrgentStart, always set LOAD_BACKGROUND, r=edgar,tnikkel+tnikkel
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

== Change summary for alert #26163 (as of Tue, 09 Jun 2020 10:20:28 GMT) ==

Regressions:

6% raptor-tp6-facebook-redesign-firefox-cold not-replayed windows10-64-shippable opt 319.88 -> 337.83
3% raptor-tp6-facebook-redesign-firefox-cold confidence macosx1014-64-shippable opt 89.17 -> 86.50

Improvements:

18% raptor-tp6-facebook-redesign-firefox-cold fcp linux64-shippable opt 1,026.00 -> 844.17
17% raptor-tp6-facebook-redesign-firefox-cold fcp windows10-64-shippable-qr opt 956.00 -> 790.25
17% raptor-tp6-facebook-redesign-firefox-cold windows7-32-shippable opt 971.75 -> 805.53
17% raptor-tp6-facebook-redesign-firefox-cold windows10-64-shippable-qr opt 920.06 -> 763.73
17% raptor-tp6-facebook-redesign-firefox-cold windows10-64-shippable opt 986.99 -> 820.19
16% raptor-tp6-facebook-redesign-firefox-cold fcp linux64-shippable-qr opt 1,078.25 -> 902.42
16% raptor-tp6-facebook-redesign-firefox-cold fcp windows10-64-shippable opt 1,066.75 -> 896.08
16% raptor-tp6-facebook-redesign-firefox-cold fcp windows7-32-shippable opt 1,069.42 -> 898.75
14% raptor-tp6-facebook-redesign-firefox-cold windows10-64-shippable-qr opt 894.87 -> 766.01
13% raptor-tp6-facebook-redesign-firefox-cold fcp macosx1014-64-shippable opt 1,506.25 -> 1,304.42
13% raptor-tp6-facebook-redesign-firefox-cold linux64-shippable opt 921.44 -> 798.83
13% raptor-tp6-facebook-redesign-firefox-cold linux64-shippable-qr opt 953.73 -> 830.24
10% raptor-tp6-facebook-redesign-firefox-cold macosx1014-64-shippable opt 1,378.67 -> 1,234.60
8% raptor-tp6-yahoo-mail-firefox-cold not-replayed linux64-shippable opt 350.08 -> 323.17
7% raptor-tp6-yahoo-mail-firefox-cold not-replayed linux64-shippable-qr opt 351.50 -> 325.67
7% raptor-tp6-yahoo-mail-firefox-cold not-replayed macosx1014-64-shippable opt 342.08 -> 318.92
3% raptor-tp6-yahoo-mail-firefox-cold confidence linux64-shippable opt 72.58 -> 74.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26163

Keywords: perf-alert
See Also: → 1647646
You need to log in before you can comment on or make changes to this bug.