Closed
Bug 1642166
Opened 4 years ago
Closed 4 years ago
Vertically align the Reader control hover labels
Categories
(Toolkit :: Reader Mode, defect, P3)
Toolkit
Reader Mode
Tracking
()
RESOLVED
FIXED
mozilla79
People
(Reporter: itiel_yn8, Assigned: itiel_yn8)
Details
Attachments
(2 files)
12.20 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
They should be 2px higher.
Updated•4 years ago
|
Severity: -- → S4
Priority: -- → P1
Updated•4 years ago
|
Priority: P1 → P3
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/bef16d556f09 Vertically align the Reader control hover labels r=Gijs
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Comment 4•4 years ago
|
||
Comment on attachment 9152991 [details]
Bug 1642166 - Vertically align the Reader control hover labels r?gijs
Beta/Release Uplift Approval Request
- User impact if declined: hover labels in reader mode look misaligned on non-en-US
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: n/a
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a very small CSS-only polish patch. It's not risky.
- String changes made/needed: None
Attachment #9152991 -
Flags: approval-mozilla-beta?
Comment 5•4 years ago
|
||
Comment on attachment 9152991 [details]
Bug 1642166 - Vertically align the Reader control hover labels r?gijs
css fix for reader mode, approved for 78.0b5
Attachment #9152991 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•4 years ago
|
||
bugherder uplift |
status-firefox78:
--- → fixed
Updated•4 years ago
|
QA Whiteboard: [qa-78b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•