Closed Bug 1642166 Opened 1 month ago Closed 1 month ago

Vertically align the Reader control hover labels

Categories

(Toolkit :: Reader Mode, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: itiel_yn8, Assigned: itiel_yn8)

Details

Attachments

(2 files)

Attached image Screenshot

They should be 2px higher.

Also cleanup the CSS a bit

Severity: -- → S4
Priority: -- → P1
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bef16d556f09
Vertically align the Reader control hover labels r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

Comment on attachment 9152991 [details]
Bug 1642166 - Vertically align the Reader control hover labels r?gijs

Beta/Release Uplift Approval Request

  • User impact if declined: hover labels in reader mode look misaligned on non-en-US
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: n/a
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is a very small CSS-only polish patch. It's not risky.
  • String changes made/needed: None
Attachment #9152991 - Flags: approval-mozilla-beta?

Comment on attachment 9152991 [details]
Bug 1642166 - Vertically align the Reader control hover labels r?gijs

css fix for reader mode, approved for 78.0b5

Attachment #9152991 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-78b-p2]
You need to log in before you can comment on or make changes to this bug.