1642195 - Library : incorrect hover css effect on toolbar buttons for dark mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Jerome Fray]

Attachment: incorrect hover css effect on toolbar buttons for dark mode.png

In dark mode, hovering on toolbar buttons shows the hover css effect for light mode.

Comment 1

[Jerome Fray]

Attachment: Bug 1642195 - Library: fix hover styling for toolbar buttons in dark mode. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ddec8a3db71b
Library: fix hover styling for toolbar buttons in dark mode. r=dao

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ddec8a3db71b

Comment 4

[Andrei Purice]

Hey Jerome,
Can you tell me what's the theme more specifically because for me if I switch to the dark theme and reach the Show all History (Library) it's still white?

Comment 5

[Dão Gottwald [:dao]]

(In reply to Andrei Purice from comment #4)

Hey Jerome,
Can you tell me what's the theme more specifically because for me if I switch to the dark theme and reach the Show all History (Library) it's still white?

You need to enable OS-wide dark mode.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Attachment: FX78 compared to Fx79

I don't see any difference with the fix in Fx79. Are there any other special settings to be set beside OS dark mode on Win10?

Comment 7

[Dão Gottwald [:dao]]

(In reply to Timea Cernea [:tbabos] from comment #6)

Created attachment 9165349 [details]
FX78 compared to Fx79

I don't see any difference with the fix in Fx79. Are there any other special settings to be set beside OS dark mode on Win10?

The background color change on hover looks different, as expected.

Comment 8

[Timea Cernea [:tbabos][inactive]]

Ah, I was looking at the tooltip background color for some reason. Thanks for pointing it out!
Verified-fixed on latest Firefox Beta 79.0 on Windows 10.