Closed Bug 1642228 Opened 2 years ago Closed 5 months ago

Investigate whether callers to css::Loader::HasPendingLoads() should account for constructable stylesheets.

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: emilio, Assigned: nordzilla)

References

Details

It seems like most of them don't, bug this one looks like it might want to, and it's web observable: https://searchfox.org/mozilla-central/rev/5e4d4827aa005d031580d2d17a01bae1af138b2e/layout/style/FontFaceSet.cpp#1574-1576

In particular, should FontFaceSet resolve its ready promise if there are constructable sheets that are being parsed and are adopted into some connected node tree?

Blocks: 1520690
No longer blocks: 1642227
See Also: → 1642227

Right now, replace() does not trigger any loads, because @import rules are disallowed.

These restrictions may be relaxed in the future, and it would probably be strange if the loads triggered by @import rules within replace() notified observers but replace() itself did not.

I think it would be best to let css::Loader::HasPendingLoads() account for constructed sheets.

Assignee: nobody → enordin
Severity: -- → S3

I think it's fine for these not to deal with HasPendingLoads, it shouldn't block the load event etc.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.