Closed Bug 1642236 Opened 1 month ago Closed 1 month ago

Make all printing "print as is" printing

Categories

(Core :: Printing: Setup, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [print2020_v79])

Attachments

(1 file)

Prior to bug 1552785 we had print dialog UI to allow the user to select "Print each frame individually" which would print each frame in a frameset consecutively. One of the pieces of cruft that has been left behind after that removal is non-print-as-is code paths. We should remove that code.

nsPrintObject::InitAsNestedObject made sure that all nsPrintObjects were set to
print-as-is except for frameset documents and their sub-documents. (Note the
setting of mParent->mPrintAsIs, which would actually set the root nsPrintObject
to print-as-is if it wasn't a frameset document!).

The SetPrintAsIs() calls in nsPrintJob::EnablePOsForPrinting would then
subsequently also set those frameset and frame nsPrintObjects to be print-as-is
in all but one edge case, namely printing a selection when there isn't a focused
window (which I'm not sure is even be possible).

Bob: note that in addition to being built on the move of some of the print-as-is code in bug 1642162, this is also built on the significant refactoring of nsPrintJob::EnablePOsForPrinting that was carried out in bug 1642167 (which may not have merged to m-c before you come to review this).

Depends on: 1642162, 1642167
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/f8a46fbea1f6
Make all printing "print as is" printing. r=bobowen
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.