1642258 - role="alert" for WebRTC indicator doesn't work

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P1)

Description

[James Teh [:Jamie]]

The legacy WebRTC sharing indicator sets role="alert" on the window element. After the fix for bug 1610596, which disallows roles other than document, dialog or application, this no longer works. Setting it on the body element (as the new indicator will do) fails for the same reason.

Bug 1610596 was necessary to comply with the ARIA spec and avoid brokenness for Orca. That's still the correct decision. However, I think it's reasonable to allow role="alert" for chrome documents.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1642258: Allow role="alert" on the body of chrome documents (but not content documents).

Also fixes a typo in an existing test that meant we weren't actually testing as intended.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bbbf98b5a9c
Allow role="alert" on the body of chrome documents (but not content documents). r=MarcoZ

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5bbbf98b5a9c

Comment 4

[James Teh [:Jamie]]

Comment on attachment 9153050 [details]
Bug 1642258: Allow role="alert" on the body of chrome documents (but not content documents).

Beta/Release Uplift Approval Request

• User impact if declined: Screen reader users won't be aware of the microphone/camera/screen sharing indicator.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Straightforward change affecting a very specific area of accessibility code. Well covered by tests.
• String changes made/needed:

Comment 5

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9153050 [details]
Bug 1642258: Allow role="alert" on the body of chrome documents (but not content documents).

a11y fix for 78.0b3

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/39d996685740