Closed Bug 1642261 Opened 4 years ago Closed 4 years ago

add telemetry for -moz-appearance usage

Categories

(Core :: CSS Parsing and Computation, task, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla79
Tracking Flags:
Tracking Status
firefox79 --- fixed

People

(Reporter: heycam, Assigned: heycam)

References

Details

Attachments

(4 files)

data review request
2.15 KB, text/plain
chutten
: data-review+
Details
Bug 1642261 - Part 1: Trivial test tweak.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1642261 - Part 2: Add telemetry for -moz-appearance usage.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1642261 - Part 3: Refactor browser_use_counters.js.
47 bytes, text/x-phabricator-request
Details | Review
No description provided.
Attached file data review request —
Attachment #9153065 - Flags: data-review?(chutten)
Comment on attachment 9153065 [details]
data review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is a Use Counter so is documented in its definitions file [UseCounters.conf](https://hg.mozilla.org/mozilla-central/file/tip/dom/base/UseCounters.conf)

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Cameron McCormack is responsible.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

    Is the data collection request for default-on or default-off?

Default on for all channels.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

No. This collection is permanent.

---
Result: datareview+
Attachment #9153065 - Flags: data-review?(chutten) → data-review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/68456151c046
Part 1: Trivial test tweak. r=emilio
https://hg.mozilla.org/integration/autoland/rev/32b26c1984f6
Part 2: Add telemetry for -moz-appearance usage. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/23927 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR was closed without merging
Backout by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e4f67b67b7f
Backed out 2 changesets for mochitest failures on test_property_database.html . CLOSED TREE

Thanks for backing out. Looks like I forgot this morning when hitting land that I didn't check my try run results!

Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/308d2f7a4a13
Part 1: Trivial test tweak. r=emilio
https://hg.mozilla.org/integration/autoland/rev/dd4c99038ede
Part 2: Add telemetry for -moz-appearance usage. r=emilio
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Backed out 2 changesets (bug 1642261) for browser_use_counters.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=os%2Cx%2C10.14%2Cdebug%2Cmochitests%2Ctest-macosx1014-64%2Fdebug-mochitest-browser-chrome-e10s-4%2Cm%28bc4%29&fromchange=dd4c99038edea872e91ff5fbb004fa8c5fe7c8ea&tochange=fb5ee52cb42c4d4b214ead6d324a0a664b738dcb&selectedTaskRun=ejzeIH3zRUK5l5lzwLdFmg-0

Backout link: https://hg.mozilla.org/integration/autoland/rev/39185e9b6a640f9a919308f2036c2c26741dda6a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=304875322&repo=autoland&lineNumber=16334

...
[task 2020-06-03T08:08:18.262Z] 08:08:18     INFO - checking file_use_counter_svg_currentScale.svg as image with histogram CSS_PROPERTY_Fill
[task 2020-06-03T08:08:18.262Z] 08:08:18     INFO - Buffered messages logged at 08:08:06
[task 2020-06-03T08:08:18.262Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | page counts for CSS_PROPERTY_Fill after are correct - 
[task 2020-06-03T08:08:18.262Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | document counts for CSS_PROPERTY_Fill after are correct - 
[task 2020-06-03T08:08:18.263Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct - 
[task 2020-06-03T08:08:18.263Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct - 
[task 2020-06-03T08:08:18.263Z] 08:08:18     INFO - checking file_use_counter_svg_fill_pattern.svg with histogram CSS_PROPERTY_FillOpacity
[task 2020-06-03T08:08:18.263Z] 08:08:18     INFO - Buffered messages logged at 08:08:15
[task 2020-06-03T08:08:18.263Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct - 
[task 2020-06-03T08:08:18.263Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct - 
[task 2020-06-03T08:08:18.264Z] 08:08:18     INFO - checking file_use_counter_svg_fill_pattern_internal.svg with histogram CSS_PROPERTY_FillOpacity
[task 2020-06-03T08:08:18.264Z] 08:08:18     INFO - Buffered messages logged at 08:08:18
[task 2020-06-03T08:08:18.264Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | page counts for CSS_PROPERTY_FillOpacity after are correct - 
[task 2020-06-03T08:08:18.264Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | document counts for CSS_PROPERTY_FillOpacity after are correct - 
[task 2020-06-03T08:08:18.264Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | top level document counts are correct - 
[task 2020-06-03T08:08:18.268Z] 08:08:18     INFO - TEST-PASS | dom/base/test/browser_use_counters.js | document counts are correct - 
[task 2020-06-03T08:08:18.268Z] 08:08:18     INFO - Leaving test bound 
[task 2020-06-03T08:08:18.268Z] 08:08:18     INFO - Entering test bound 
[task 2020-06-03T08:08:18.268Z] 08:08:18     INFO - Leaving test bound 
[task 2020-06-03T08:08:18.268Z] 08:08:18     INFO - Buffered messages finished
[task 2020-06-03T08:08:18.268Z] 08:08:18     INFO - TEST-UNEXPECTED-FAIL | dom/base/test/browser_use_counters.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. - 
[task 2020-06-03T08:08:18.269Z] 08:08:18     INFO - GECKO(2217) | MEMORY STAT | vsize 7872MB | residentFast 485MB | heapAllocated 116MB
[task 2020-06-03T08:08:18.269Z] 08:08:18     INFO - TEST-OK | dom/base/test/browser_use_counters.js | took 207661ms
Flags: needinfo?(cam)
Upstream PR was closed without merging

The timeouts on macOS for browser_use_counters.js required some substantial refactoring of that test:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6721c5fe58dd986126e3b2fc5d9418439fe0e7e2

Flags: needinfo?(cam)

This refactoring achieves a few things:

  1. Removing the repetition between the different check_use_counter_xxx
    functions.
  2. Increasing the number of repetitions that
    BrowserTestUtils.waitForCondition uses so that we have intermittently
    failures resulting from it reaching its maximum repetitions.
  3. Checking all telemetry histograms from the one document at once,
    rather than re-loading the document for each histogram checked.
    (This saves a lot of time, and was the cause of macOS timeouts after
    the -moz-appearance use counter checks were added.)
  4. A change to use a CSS property use counter as a sentinel to determine
    whether telemetry has been reported yet, rather than the number of
    documents destroyed, since the browser might be loading various other
    documents in the background that can cause us to advance the test
    before telemetry has been reported.
Blocks: 1576647
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e59f01bfdeb
Part 1: Trivial test tweak. r=emilio
https://hg.mozilla.org/integration/autoland/rev/c1ce12bc1d96
Part 2: Add telemetry for -moz-appearance usage. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3cde4e2d064b
Part 3: Refactor browser_use_counters.js. r=emilio
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

https://hg.mozilla.org/mozilla-central/rev/2e59f01bfdeb
https://hg.mozilla.org/mozilla-central/rev/c1ce12bc1d96
https://hg.mozilla.org/mozilla-central/rev/3cde4e2d064b

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Upstream PR merged by moz-wptsync-bot
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8a1f6badc615
Port bug 1642261 - Add forms.css to browser_parsable_css.js whitelist. rs=bustage-fix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: