1642317 - RuntimeError: File "chrome/calendar/calendar-alarms.properties" not found in /builds/worker/workspace/obj-build/comm/mail/locales/merge-dir/ast/calendar

Status: RESOLVED FIXED

(Calendar :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin+mozilla [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=304517291&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/b2XaTXjOTmyvfUgzyuziQw/runs/0/artifacts/public/logs/live_backing.log

---

RuntimeError: File "chrome/calendar/calendar-alarms.properties" not found in /builds/worker/workspace/obj-build/comm/mail/locales/merge-dir/ast/calendar

I think to note here it's trying to get a calendar properties files for comm/mail but should be for comm/calendar

Comment 1

[Magnus Melin [:mkmelin]]

I'm assuming bug 1641184 is the regressing bug. These reds were first see https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=aa0ea60ab031095e06721e9dcd08c0cdd2766469 which would fit the time frame.

Comment 2

[Axel Hecht [:Pike]]

This isn't really a regression, the problem just changed behavior. I mentioned this to Rob on matrix, ast missing from the calendar locales list.

Thus, it's not merged, and busted. That bustage went from runtime to build time only.

Comment 3

[Magnus Melin [:mkmelin]]

I see, thx!

But there is no ast project of https://pontoon.mozilla.org/projects/lightning/ - so I guess one can't just add 'ast' to the l10n.toml list

Comment 4

[Magnus Melin [:mkmelin]]

It's a very small language (100k according to wikipedia). The thunderbird project for it is also not that active - https://pontoon.mozilla.org/ast/thunderbird/ with last activity in 2017. I guess we might consider dropping it from Thunderbird until it's in better shape.

Comment 5

[Francesco Lodolo [:flod]]

Adding to the TOML file is independent from Pontoon, it can be done at different times. Also, Enol has been active recently, it might be worth asking his opinion.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: bug1642317_cal_ast.patch

I that case, I guess we might as well add it for calendar at least until we figure out if it's worth shipping.

Comment 7

[Magnus Melin [:mkmelin]]

Enol, any opinion on the state of the Asturian localization? There is none for lightning (which is now part of thunderbird).
Is it worth shipping in current state?

Comment 8

[Rob Lemley [:rjl]]

Comment on attachment 9153176 [details] [diff] [review]
bug1642317_cal_ast.patch

Review of attachment 9153176 [details] [diff] [review]:
-----------------------------------------------------------------

This looks okay in terms of fixing the broken build. I ran a try build then added the L10n-repackage-ast job manually to verify.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=038bdbae05c8eb4a57102b7c3c12665f3c10c5a7

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fa07bf30c747
add ast (Asturian) to calendar l10n.toml since not matching the Thunderbird l10n.toml is now an error. r=rjl

Comment 10

[Magnus Melin [:mkmelin]]

Comment on attachment 9153176 [details] [diff] [review]
bug1642317_cal_ast.patch

Needed to fix failure on beta.

Comment 12

[Magnus Melin [:mkmelin]]

Landed for 78 beta: https://hg.mozilla.org/releases/comm-beta/rev/4e696582a089751e4ae1f02cea6add023366a3c5

Comment 13

[Intermittent Failures Robot]

2 failures in 4949 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 2

Platform breakdown:

• linux64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642317&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 14

[enolp]

First of all, I'm so sorry for not being able to respond to your questions. So many projects, so many emails and a little free time are the problem here, my very deepest apologies.

As I can see, this bug is fixed but if you need me to change some string, I'll do it. Pontoon lacks the feature of PM users or is barely used.

Anyway, Asturian translations are fine, they only need a bit of maintenance. I'll check them when I have time.

Thank you and bye.