Closed Bug 1642328 Opened 1 month ago Closed 1 month ago

Marionette's print.printToFile takes a MozBrowser, not an nsIFrameLoader

Categories

(Testing :: Marionette, task, P4)

task

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Marionette's print.printToFile's first argument is named 'frameLoader', suggesting that it takes an nsIFrameLoader. The only caller of this function passes a MozBrowser though.

The print methods on both frameLoader and MozBrowser have identical signatures so this works, but we should probably rename this argument to reflect reality.

This new method has been added recently via bug 1638839.

See Also: → 1638839
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/autoland/rev/4930c42c5866
Marionette's print.printToFile takes a MozBrowser, not an nsIFrameLoader. r=jgraham,marionette-reviewers,whimboo
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.