1642358 - Only record the "last user hash" for the sync merge warning after account becomes verified

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P3)

Description

[Alex Davis [:adavis]]

Steps to reproduce:

• Create a new profile
• Try to register with an invalid email (one that will bounce but looks legit)
• When you see the FxA error that the email bounced, start over

Results:

• Sync gives a merge warning though the first attempt at registation never worked

Expected result:

• No merge warning since it's the first successful Sync authentication.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

We now record that "last user hash" as soon as we are told of the login. I think doing it as we notice verification would avoid the issue as described.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:rfkelly, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Ryan Kelly [:rfkelly]]

I'm making this a P3, but if we have metrics to suggest it's a regularly-occurring problem we can discuss bumping it up.

Comment 4

[Ben Dean-Kawamura [:bdk]]

I'm not seeing an email bounced error when running from the current code, but I do see this issue if I click the "Use a different account" link from the login page before the first account is verified.

Comment 5

[Ben Dean-Kawamura [:bdk]]

Attachment: Bug 1642358: Don't save the last user hash for unverified emails. r=markh

• Updated FxAccountsWebChannel to not save the user hash when logging in
  with an unverified email
• Updated FxAccounts to save the user hash once the email is verified.
• Updated tests

Comment 6

[Mark Hammond [:markh] [:mhammond]]

(In reply to Ben Dean-Kawamura from comment #4)

I'm not seeing an email bounced error when running from the current code, but I do see this issue if I click the "Use a different account" link from the login page before the first account is verified.

That would be the server - might be worth asking on #fxa about it if you can reproduce it - bounces are a bit of a problem for them and they might be interested in working out what made yours bounce.

Comment 7

[Ben Dean-Kawamura [:bdk]]

@markh can you add the testing tag to phabricator?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81ca3e5099af
Don't save the last user hash for unverified emails.  r=markh

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/81ca3e5099af