1642398 - Prefer a single document.l10n.formatValues call to multiple document.l10n.formatValue calls.

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Dave Townsend [:mossop]]

Not sure how lintable this is but we should prefer document.l10n.formatValues over multiple calls to document.l10n.formatValue. See https://searchfox.org/mozilla-central/source/browser/base/content/pageinfo/pageInfo.js#291-303 for a poor example.

I was thinking that maybe we could lint for multiple calls to document.l10n.formatValue in the same code block.

Comment 1

[Dave Townsend [:mossop]]

I think we should probably block on bug 1642423 for this to get a nicer syntax.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Bug 1642398: Add a lint rule to warn about multiple calls to document.l10n.formatValue. r=Standard8!

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:mossop, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 4

[Dave Townsend [:mossop]]

This patch cannot land until the lints it complains about are fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9b23a8775ca
Add a lint rule to warn about multiple calls to document.l10n.formatValue. r=Standard8,preferences-reviewers,ntim

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d9b23a8775ca

Comment 7

[Florin Strugariu [:Bebe]]

== Change summary for alert #26519 (as of Thu, 16 Jul 2020 06:24:24 GMT) ==

Improvements:

33% build times windows2012-32-shippable opt instrumented taskcluster-c5.4xlarge 2,196.05 -> 1,478.37
32% build times windows2012-32-shippable opt instrumented taskcluster-c5d.4xlarge 2,189.45 -> 1,498.75
28% build times windows2012-32-shippable opt instrumented taskcluster-m5.4xlarge 2,280.53 -> 1,637.17

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26519

Comment 8

[Mike Hommey [:glandium]]

(In reply to Florin Strugariu [:Bebe] (needinfo me) from comment #7)

== Change summary for alert #26519 (as of Thu, 16 Jul 2020 06:24:24 GMT) ==

Improvements:

33% build times windows2012-32-shippable opt instrumented taskcluster-c5.4xlarge 2,196.05 -> 1,478.37
32% build times windows2012-32-shippable opt instrumented taskcluster-c5d.4xlarge 2,189.45 -> 1,498.75
28% build times windows2012-32-shippable opt instrumented taskcluster-m5.4xlarge 2,280.53 -> 1,637.17

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26519

This is misattribution. The improvement comes from bug 1651938.