1642423 - document.l10n.formatValues should accept strings as well as L10nKeys

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Dave Townsend [:mossop]]

Formatting multiple values is pretty verbose in the common case:

await document.l10n.formatValues([
  { id: "value1" },
  { id: "value2" },
  { id: "value3" },
]);

If instead elements of the array could optionally be strings it could be simpler:

await document.l10n.formatValues([
  "value1",
  "value2",
  "value3",
]);

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1642423: document.l10n.formatValues should accept simple strings as well as L10nKeys. r=zbraniecki!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b5928fd85e5
document.l10n.formatValues should accept simple strings as well as L10nKeys. r=zbraniecki

Comment 3

[Atila Butkovits]

Backed out for causing failure at test_getAttributes.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a360635bc81723e26ff35509ee5a5fd38268a5b6

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=CQH1fR6qTb2zSLhf-rfV6Q-0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=3b5928fd85e56855d31055aa8b0797b22f3c8499&failure_classification_id=2

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305267542&repo=autoland&lineNumber=5434
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305267171&repo=autoland&lineNumber=46795
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305271067&repo=autoland&lineNumber=2565

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/329f82b99110
document.l10n.formatValues should accept simple strings as well as L10nKeys. r=zbraniecki

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/329f82b99110