1642467 - Toolbarbuttons break when localizing them using Fluent

Status: RESOLVED INVALID

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Max]

Attachment: demo.patch

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.61 Safari/537.36 Edg/83.0.478.37

Steps to reproduce:

Localize a Toolbarbutton using Fluent with the exact same String as before.

The attached patch is a proof of concept using the "Get Messages" button. All other Toolbarbuttons are similarly affected.

Actual results:

The Toolbarbutton breaks and becomes completely dysfunctional.

Expected results:

The Toolbarbutton should behave exactly the same as before.

Comment 1

[Magnus Melin [:mkmelin] (away, back June 30)]

You need to use .label and such to set the appropriate attributes instead. Like
https://searchfox.org/comm-central/source/mozilla/browser/locales/en-US/browser/customizeMode.ftl#16