Closed Bug 1642470 Opened 1 month ago Closed 1 month ago

Devtools should use LoadInfo.browsingContextID.top.id instead of LoadInfo.topOuterWindowID when matching requests in network-observer

Categories

(DevTools :: General, enhancement)

enhancement

Tracking

(Fission Milestone:M6c, firefox79 fixed)

RESOLVED FIXED
Firefox 79
Fission Milestone M6c
Tracking Status
firefox79 --- fixed

People

(Reporter: annyG, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission-m2-mvp)

Attachments

(1 file)

In bug 1642468 I plan to replace usages of outer windowID's in LoadInfo with corresponding browsing context IDs. In bug 1642469 I will add mTopBrowsingContextID field to LoadInfo so that network observer in devtools can be changed to use it instead of mTopOuterWindowID.

Blocks: 1642471

Actually, we don't even need mTopBrowsingContextID field for LoadInfo as JS code can use loadInfo.browsingContext.top.id instead of loadInfo.topOuterWindowID here https://searchfox.org/mozilla-central/rev/8ccea36c4fb09412609fb738c722830d7098602b/devtools/server/actors/network-monitor/network-observer.js#126

Fission Milestone: --- → M6c

so channel.loadInfo && channel.loadInfo.topOuterWindowID == can be replaced with channel.loadInfo && channel.loadInfo.browsingContext && channel.loadInfo.browsingContext.top.id ==

Summary: Devtools should use LoadInfo.topBrowsingContextID instead of LoadInfo.topOuterWindowID when matching requests in network-observer → Devtools should use LoadInfo.browsingContextID.top.id instead of LoadInfo.topOuterWindowID when matching requests in network-observer

Alex, this is a Fission task for the DevTools team. The network observer should switch to this alternate API (loadInfo.browsingContext.top.id) now to avoid getting broken when the old API (loadInfo.topOuterWindowID) is removed (in bug 1642468).

Flags: needinfo?(poirot.alex)
No longer depends on: 1642469

Sorry for the delay, I'll look into this.

This actually looks helpful regarding the ongoing refactorings we are doing for network monitor to support Fission!

Assignee: nobody → poirot.alex
Flags: needinfo?(poirot.alex)
Whiteboard: dt-fission-m2-mvp

OuterWindow ID is deprecated in a Fission world and we should rather use Browsing Context ID.
The outer window ID will change when navigating to another origin, loaded in a distinct process,
whereas Browsing Context ID will stay the same.

Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b89bc5ad34e2
Use BrowsingContext ID instead of outerWindowID to filter out netmonitor requests. r=bomsy,Honza
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
You need to log in before you can comment on or make changes to this bug.