1642470 - Devtools should use LoadInfo.browsingContextID.top.id instead of LoadInfo.topOuterWindowID when matching requests in network-observer

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Anny Gakhokidze [:annyG]]

In bug 1642468 I plan to replace usages of outer windowID's in LoadInfo with corresponding browsing context IDs. In bug 1642469 I will add mTopBrowsingContextID field to LoadInfo so that network observer in devtools can be changed to use it instead of mTopOuterWindowID.

Comment 1

[Anny Gakhokidze [:annyG]]

Actually, we don't even need mTopBrowsingContextID field for LoadInfo as JS code can use loadInfo.browsingContext.top.id instead of loadInfo.topOuterWindowID here https://searchfox.org/mozilla-central/rev/8ccea36c4fb09412609fb738c722830d7098602b/devtools/server/actors/network-monitor/network-observer.js#126

Comment 2

[Anny Gakhokidze [:annyG]]

so channel.loadInfo && channel.loadInfo.topOuterWindowID == can be replaced with channel.loadInfo && channel.loadInfo.browsingContext && channel.loadInfo.browsingContext.top.id ==

Comment 3

[Chris Peterson [:cpeterson]]

Alex, this is a Fission task for the DevTools team. The network observer should switch to this alternate API (loadInfo.browsingContext.top.id) now to avoid getting broken when the old API (loadInfo.topOuterWindowID) is removed (in bug 1642468).

Comment 4

[Alexandre Poirot [:ochameau]]

Sorry for the delay, I'll look into this.

This actually looks helpful regarding the ongoing refactorings we are doing for network monitor to support Fission!

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1642470 - Use BrowsingContext ID instead of outerWindowID to filter out netmonitor requests.

OuterWindow ID is deprecated in a Fission world and we should rather use Browsing Context ID.
The outer window ID will change when navigating to another origin, loaded in a distinct process,
whereas Browsing Context ID will stay the same.

Comment 6

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dad8f3393ca471194e73aa2f7fe78b1cc819f6c2

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b89bc5ad34e2
Use BrowsingContext ID instead of outerWindowID to filter out netmonitor requests. r=bomsy,Honza

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b89bc5ad34e2