Closed Bug 1642511 Opened 4 years ago Closed 9 months ago

[wpt-sync] Sync PR 23904 - Correct CSS2/css1/c414-flt-fit-000.xht and reference

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23904 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23904
Details from upstream follow.

Sam Sneddon <me@gsnedders.com> wrote:

Correct CSS2/css1/c414-flt-fit-000.xht and reference

The reference did not match the test, as it did not have navy everywhere the test had it. This fixes this by removing the navy from both test and reference, as it served no purpose.

Additionally, the test depended upon the width of the nbsp relative to the em-square; having observed this varying, this is now fixed by making the table monospace in both test and reference.

Closes #8834. cc/ @TalbotG given he made most of the review comments before (I don't this contains anything you disagreed with, though?). Note that unlike #8834, this doesn't change any width given browsers seem to be interoperable with what the test already had (and @TalbotG believed correct).

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d506925c6e69
[wpt PR 23904] - Correct CSS2/css1/c414-flt-fit-000.xht and reference, a=testonly
https://hg.mozilla.org/integration/autoland/rev/88ed2323ff20
[wpt PR 23904] - Update wpt metadata, a=testonly

Upstream PR 23904 has been merged.

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.