1642517 - mach try scriptworker "expected string or bytes-like object"

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[Mitchell Hentges [:mhentges] 🦀]

When invoking ./mach try scriptworker with Python 3, I see the following error:

TypeError: expected string or bytes-like object

  File "c:\dev\firefox\tools/tryselect/mach_commands.py", line 446, in try_scriptworker
    return self.run(**kwargs)
  File "c:\dev\firefox\tools/tryselect/mach_commands.py", line 178, in run
    return mod.run(**kwargs)
  File "c:\dev\firefox\tools\tryselect\selectors\scriptworker.py", line 126, in run
    release = get_releases(RELEASE_TO_BRANCH[release_type])[-1]
  File "c:\dev\firefox\tools\tryselect\selectors\scriptworker.py", line 77, in get_releases
    headers={"Accept": ["application/json"]},
  File "c:\dev\firefox\third_party/python/requests\requests\api.py", line 67, in get
    return request('get', url, params=params, **kwargs)
  File "c:\dev\firefox\third_party/python/requests\requests\api.py", line 53, in request
    return session.request(method=method, url=url, **kwargs)
  File "c:\dev\firefox\third_party/python/requests\requests\sessions.py", line 468, in request
    resp = self.send(prep, **send_kwargs)
  File "c:\dev\firefox\third_party/python/requests\requests\sessions.py", line 576, in send
    r = adapter.send(request, **kwargs)
  File "c:\dev\firefox\third_party/python/requests\requests\adapters.py", line 376, in send
    timeout=timeout
  File "c:\dev\firefox\third_party/python/requests\requests\packages\urllib3\connectionpool.py", line 559, in urlopen
    body=body, headers=headers)
  File "c:\dev\firefox\third_party/python/requests\requests\packages\urllib3\connectionpool.py", line 353, in _make_request
    conn.request(method, url, **httplib_request_kw)
  File "c:\mozilla-build\python3\lib\http\client.py", line 1244, in request
    self._send_request(method, url, body, headers, encode_chunked)
  File "c:\mozilla-build\python3\lib\http\client.py", line 1285, in _send_request
    self.putheader(hdr, value)
  File "c:\mozilla-build\python3\lib\http\client.py", line 1221, in putheader
    if _is_illegal_header_value(values[i]):

Comment 1

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1642517: Resolves |mach try scriptworker| py3 issue r?rstewart

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d701679954b8
Resolves |mach try scriptworker| py3 issue r=rstewart

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/d701679954b8

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1632429

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mhentges, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Mitchell Hentges [:mhentges] 🦀]

I don't believe this will require an uplift, since it's try