1642522 - "this._attachmentIds.get(...) is undefined" in ext-compose.js

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Geoff Lankow (:darktrojan)]

If the compose API is used but not for attachments, every time a compose window is closed it tries to forget attachments it wasn't remembering.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1642522-forget-attachment-undefined.diff

This is the easiest thing I've had to fix in a while. :-/

Comment 2

[Magnus Melin [:mkmelin]]

(In reply to Geoff Lankow (:darktrojan) from comment #0)

If the compose API is used but not for attachments, every time a compose window is closed it tries to forget attachments it wasn't remembering.

I don't understand what it's doing then. Seems this is called only once: https://searchfox.org/comm-central/rev/eaa4c5e724230d661b587d05cabfd485ecad84df/mail/components/extensions/parent/ext-compose.js#337

So it's calling the function with some junk? Or why wasn't it remembering them?

Comment 3

[Geoff Lankow (:darktrojan)]

They're only in that Map if an extension has done something with attachments. The forgetAttachments call is made whether or not there's attachments in the Map.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9153289 [details] [diff] [review]
1642522-forget-attachment-undefined.diff

Review of attachment 9153289 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/components/extensions/parent/ext-compose.js
@@ +322,5 @@
>      return this._attachments.has(id);
>    },
>  
>    forgetAttachment(attachment) {
> +    let id = this._attachmentIds.get(attachment)?.id;

Please add a code comment about it.

@@ +327,1 @@
>      this._attachmentIds.delete(attachment);

Seems this should also be in the if clause. Pointless to try to delete if it wasn't there.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/eac3756825da
Fix "this._attachmentIds.get(...) is undefined" in ext-compose.js. r=mkmelin

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9153289 [details] [diff] [review]
1642522-forget-attachment-undefined.diff

[Triage Comment]
Approved for beta

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 78.0b1:
https://hg.mozilla.org/releases/comm-beta/rev/71067085a232