1642536 - Intermittent comm/mail/test/browser/attachment/browser_attachmentEvents.js | false == true - JS frame :: chrome://mochitests/content/browser/comm/mail/test/browser/attachment/browser_attachmentEvents.js :: test_attachments_pane_toggle :: line 450

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: geoff [at] darktrojan.net
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=304657169&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Yc-XeEx4TZSXF6s7PfPvkw/runs/0/artifacts/public/logs/live_backing.log

---

Comment 1

[Magnus Melin [:mkmelin] (away, back June 30)]

Attachment: bug1642536_att_event.patch

Comment 2

[Intermittent Failures Robot]

31 failures in 4949 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 30
• try-comm-central: 1

Platform breakdown:

• macosx1014-64: 12
• macosx1014-64-shippable: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642536&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79a2df41af71
browser_attachmentEvents.js - wait for the keypress to take effct. r=darktrojan

Comment 4

[Magnus Melin [:mkmelin] (away, back June 30)]

Looks like it didn't help :(

Comment 5

[Intermittent Failures Robot]

31 failures in 5211 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 31

Platform breakdown:

• macosx1014-64: 12
• macosx1014-64-shippable: 19

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642536&startday=2020-06-08&endday=2020-06-14&tree=all

Comment 6

[Intermittent Failures Robot]

31 failures in 4035 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 31

Platform breakdown:

• macosx1014-64: 14
• macosx1014-64-shippable: 17

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642536&startday=2020-06-15&endday=2020-06-21&tree=all

Comment 7

[Magnus Melin [:mkmelin] (away, back June 30)]

Attachment: bug1642536_attachmentbox_test_fail.patch

Another stab at this. At least the problem didn't show up on try, and it's more modern.
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedTaskRun=VAYmdcimTbSYIt3dr4txEw.0&revision=5deb92128f0180f8e694819b74bb1fdf7cdbaca3

Comment 8

[Geoff Lankow (:darktrojan)]

There's a good chance it didn't show up on Try because it's only ever occurred on Mac, and your Try run was Linux only.

Comment 9

[Magnus Melin [:mkmelin] (away, back June 30)]

Comment on attachment 9158105 [details] [diff] [review]
bug1642536_attachmentbox_test_fail.patch

Yeah didn't work - https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=99925a30b490a09c09635642ddc9e398295124c4

Comment 10

[Magnus Melin [:mkmelin] (away, back June 30)]

Attachment: bug1624849_tasks_test.patch

Oh, the key is the same on mac now, that's why it's failing.

Comment 11

[Magnus Melin [:mkmelin] (away, back June 30)]

Attachment: bug1642536_attachmentbox_test_fail.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=caf8ba80dbf18f72b92f3e6130f27d97a8665e7d

Comment 12

[Magnus Melin [:mkmelin] (away, back June 30)]

Comment on attachment 9159220 [details] [diff] [review]
bug1642536_attachmentbox_test_fail.patch

Nevermind, sorry for the noise.

Comment 13

[Intermittent Failures Robot]

32 failures in 5252 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 32

Platform breakdown:

• macosx1014-64: 14
• macosx1014-64-shippable: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642536&startday=2020-06-22&endday=2020-06-28&tree=all

Comment 14

[Magnus Melin [:mkmelin] (away, back June 30)]

Khushil, can you check this - easier with a mac... see comment 10. (Not clear why it still failed, but it did.)

Comment 15

[Khushil Mistry [:khushil324]]

The shortcut is not working on the Mac so I guess it's an issue with the implementation/feature, not the test. I am looking into it.

Comment 16

[Khushil Mistry [:khushil324]]

Here, in the key "key_toggleAttachmentPane", the modifier is only "alt": https://searchfox.org/comm-central/source/mail/components/compose/content/messengercompose.xhtml#438
And we are pressing "ctrlKey" in the browser_attachmentEvents.js: https://searchfox.org/comm-central/source/mail/test/browser/attachment/browser_attachmentEvents.js#447,457

But with pressing option + m in the Mac also(option key is equivalent to alt key of Window), it's not working. Character is getting added in the focused input part. I guess event.stopPropagation gets fired after the character is inserted in the input area. We need to change this modifier. Changing this modifier to modifiers="accel alt" and pressing command + option + m, it worked. The test is also passing.

Comment 17

[Magnus Melin [:mkmelin] (away, back June 30)]

Yeah the key changed - can you look at hg blame of why?

Comment 18

[Khushil Mistry [:khushil324]]

Problem is introduced here: Bug 1625263

Comment 19

[Khushil Mistry [:khushil324]]

And the try-run that they did was for Linux only.

Comment 20

[Khushil Mistry [:khushil324]]

Attachment: Bug-1642536_fix-mochitest-browser_attachmentEvents-0.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8a83a092f9bbfb8dc96c8accd60a08c001ae7812

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4c9aee377c66
Fix mochitest browser_attachmentEvents.js. r=mkmelin

Comment 22

[Intermittent Failures Robot]

5 failures in 4516 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• macosx1014-64-shippable: 3
• macosx1014-64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1642536&startday=2020-06-29&endday=2020-07-05&tree=all

Comment 23

[Rob Lemley [:rjl]]

Comment on attachment 9160154 [details] [diff] [review]
Bug-1642536_fix-mochitest-browser_attachmentEvents-0.patch

[Approval Request Comment]
This shows up on c-esr78 on every release, lets get it taken care of.
Regression caused by (bug #): 1625263
User impact if declined:
Testing completed (on c-c, etc.): Been on beta since 80 or so
Risk to taking this patch (and alternatives if risky):
The more orange noisy tests on release, the harder it is to identify the actual problems.

Need:
https://hg.mozilla.org/comm-central/rev/79a2df41af71
https://hg.mozilla.org/comm-central/rev/4c9aee377c66

Comment 24

[Wayne Mery (:wsmwk)]

Comment on attachment 9160154 [details] [diff] [review]
Bug-1642536_fix-mochitest-browser_attachmentEvents-0.patch

[Triage Comment]
Approved for ers78

Comment 25

[Rob Lemley [:rjl]]

Thunderbird 78.2.2:
https://hg.mozilla.org/releases/comm-esr78/rev/70c04cbe328e
https://hg.mozilla.org/releases/comm-esr78/rev/d5763dbdf9a5