[wpt-sync] Sync PR 23906 - Set color-scheme-senstive initial color via cascade
Categories
(Core :: CSS Transitions and Animations, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(3 files)
Sync web-platform-tests PR 23906 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/23906
Details from upstream follow.
Anders Hartvoll Ruud <andruud@chromium.org> wrote:
Set color-scheme-senstive initial color via cascade
We currently adjust the computed value of 'color' on the document
element to simulate 'canvastext' behavior. However, there's an
incorrect assumption that it's safe to adjust whenever there are no
'color' declarations in the cascade.During a transition, the base ComputedStyle is the destination style
for the transitioning element, and on the final frame of the
transition, the StyleEngine simply emits a copy of the base style,
without adding any declaration to the cascade. This causes color-
transitions on the document element to "snap back" to black (or white,
depending on color-scheme) when the transition ends.This CL fixes this by adding an explicit value (CSSInitialColorValue)
which represents this behavior to the cascade. The value is added only
when computing the base style, which prevents incorrect adjustments on
top of the final transition frame.Bug: 1087188
Change-Id: Ie0d95aaab5b93f1749e461fad0baf41a184f7cb6
Reviewed-on: https://chromium-review.googlesource.com/2224222
WPT-Export-Revision: 3138b628824c2b8cec2b13ca47f53afad18c1fec
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e59c45e3c5f67bfda1c3ed8ee64a6072d558ff50
|
|
Assignee | |
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 1 tests
Status Summary
Firefox
PASS: 1
Chrome
FAIL: 1
Safari
PASS: 1
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c680506c9bd6 [wpt PR 23906] - Set color-scheme-senstive initial color via cascade, a=testonly
|
||
Comment 4•4 years ago
|
||
Automatic update from web-platform-tests
Set color-scheme-senstive initial color via cascade
We currently adjust the computed value of 'color' on the document
element to simulate 'canvastext' behavior. However, there's an
incorrect assumption that it's safe to adjust whenever there are no
'color' declarations in the cascade.
During a transition, the base ComputedStyle is the destination style
for the transitioning element, and on the final frame of the
transition, the StyleEngine simply emits a copy of the base style,
without adding any declaration to the cascade. This causes color-
transitions on the document element to "snap back" to black (or white,
depending on color-scheme) when the transition ends.
This CL fixes this by adding an explicit value (CSSInitialColorValue)
which represents this behavior to the cascade. The value is added only
when computing the base style, which prevents incorrect adjustments on
top of the final transition frame.
Bug: 1087188
Change-Id: Ie0d95aaab5b93f1749e461fad0baf41a184f7cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224222
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774178}
--
wpt-commits: c20b45a0352c65db0ef7f141edfd68d01f1516e2
wpt-pr: 23906
|
|
||
Comment 5•4 years ago
|
||
Automatic update from web-platform-tests
Set color-scheme-senstive initial color via cascade
We currently adjust the computed value of 'color' on the document
element to simulate 'canvastext' behavior. However, there's an
incorrect assumption that it's safe to adjust whenever there are no
'color' declarations in the cascade.
During a transition, the base ComputedStyle is the destination style
for the transitioning element, and on the final frame of the
transition, the StyleEngine simply emits a copy of the base style,
without adding any declaration to the cascade. This causes color-
transitions on the document element to "snap back" to black (or white,
depending on color-scheme) when the transition ends.
This CL fixes this by adding an explicit value (CSSInitialColorValue)
which represents this behavior to the cascade. The value is added only
when computing the base style, which prevents incorrect adjustments on
top of the final transition frame.
Bug: 1087188
Change-Id: Ie0d95aaab5b93f1749e461fad0baf41a184f7cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224222
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774178}
--
wpt-commits: c20b45a0352c65db0ef7f141edfd68d01f1516e2
wpt-pr: 23906
|
|
||
Comment 6•4 years ago
|
||
Automatic update from web-platform-tests
Set color-scheme-senstive initial color via cascade
We currently adjust the computed value of 'color' on the document
element to simulate 'canvastext' behavior. However, there's an
incorrect assumption that it's safe to adjust whenever there are no
'color' declarations in the cascade.
During a transition, the base ComputedStyle is the destination style
for the transitioning element, and on the final frame of the
transition, the StyleEngine simply emits a copy of the base style,
without adding any declaration to the cascade. This causes color-
transitions on the document element to "snap back" to black (or white,
depending on color-scheme) when the transition ends.
This CL fixes this by adding an explicit value (CSSInitialColorValue)
which represents this behavior to the cascade. The value is added only
when computing the base style, which prevents incorrect adjustments on
top of the final transition frame.
Bug: 1087188
Change-Id: Ie0d95aaab5b93f1749e461fad0baf41a184f7cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224222
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#774178}
--
wpt-commits: c20b45a0352c65db0ef7f141edfd68d01f1516e2
wpt-pr: 23906
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/37fa8012971e [wpt PR 23906] - Set color-scheme-senstive initial color via cascade, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/0c43a50f2557 [wpt PR 23906] - Set color-scheme-senstive initial color via cascade, a=testonly
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
Description
•