Closed Bug 1642677 Opened 1 month ago Closed 1 month ago

profiler_pause doesn't pause the android sampler

Categories

(Core :: Gecko Profiler, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: canova, Assigned: canova)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We are pausing the profiler before capturing it. But currently our profiler_pause function doesn't pause the java sampler as well, and that usually makes profile data to be polluted with more java samples compared to native ones. We are only pausing it just before the java serialization. We should teach profiler_pause about the android sampler.

Priority: -- → P3

Here's a profile with the very late java sampling pause: https://share.firefox.dev/3coZpRD

Severity: -- → S3

Now we are pausing the profiler just before capturing the profile data. Android
sampler will never be running when this code is being run

Depends on D78037

Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9d25fef91ab1
Pause the profiler before capturing a profile with remote profiling. r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/080cd03c38fd
Make the profiler_{pause,resume} control android sampler as well. r=gerald
https://hg.mozilla.org/integration/autoland/rev/06661f12888f
Remove the unneeded java sampler pause/unpause during the serialization. r=gerald
You need to log in before you can comment on or make changes to this bug.