1642677 - profiler_pause doesn't pause the android sampler

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect, P3)

Description

[Nazım Can Altınova [:canova]]

We are pausing the profiler before capturing it. But currently our profiler_pause function doesn't pause the java sampler as well, and that usually makes profile data to be polluted with more java samples compared to native ones. We are only pausing it just before the java serialization. We should teach profiler_pause about the android sampler.

Comment 1

[Nazım Can Altınova [:canova]]

Here's a profile with the very late java sampling pause: https://share.firefox.dev/3coZpRD

Comment 2

[Nazım Can Altınova [:canova]]

Attachment: Bug 1642677 - Pause the profiler before capturing a profile with remote profiling. r?gregtatum

Comment 3

[Nazım Can Altınova [:canova]]

Attachment: Bug 1642677 - Make the profiler_{pause,resume} control android sampler as well. r?gerald

Depends on D78036

Comment 4

[Nazım Can Altınova [:canova]]

Attachment: Bug 1642677 - Remove the unneeded java sampler pause/unpause during the serialization. r?gerald

Now we are pausing the profiler just before capturing the profile data. Android
sampler will never be running when this code is being run

Depends on D78037

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d25fef91ab1
Pause the profiler before capturing a profile with remote profiling. r=gregtatum
https://hg.mozilla.org/integration/autoland/rev/080cd03c38fd
Make the profiler_{pause,resume} control android sampler as well. r=gerald
https://hg.mozilla.org/integration/autoland/rev/06661f12888f
Remove the unneeded java sampler pause/unpause during the serialization. r=gerald

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/9d25fef91ab1
https://hg.mozilla.org/mozilla-central/rev/080cd03c38fd
https://hg.mozilla.org/mozilla-central/rev/06661f12888f