Closed Bug 1642715 Opened 4 months ago Closed 3 months ago

Activate media controller when media enters fullscreen

Categories

(Core :: Audio/Video: Playback, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

Attachments

(7 files, 1 obsolete file)

This is a request from Firefox Reality team and they want to control media before media starts. So we would like to create an API to allow them to have this behavior, but other platforms would still remain current behavior.

Early today I was discussing with Agi about what we should provide to FxR in order to reach their need, but we haven't got a conclusion yet. So I will pause doing this until we finalize the plan.

Summary: Add a new MediaControl API to allow us to control media before media starts → Activate media controller when media enters fullscreen

According to the offline discussion with agi, we would change our approach to "be able to control media when media enters fullscreen" which can achieve the requirement from FxR.

This patch would

  • notify media controller when media enters/leaves fullscreen

The advantage of doing this is

  • prework of being able to control media when media enters fullscreen
Attachment #9155834 - Attachment is obsolete: true

This patch would

  • active the controller when it enters fullscreen or picture-in-picture mode

The advantage of doing this is

  • allow to control media even if media doesn't start
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57488aa443a6
part1 : move timer to media controller. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/74f5999fa644
part2 : connect media to media controller after knowing its duration. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/84b2f31af5c7
part3 : prevent controlling inactive controller. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/8198377cf28b
part4 : notify media controller when media enters/leaves fullscreen. r=chunmin,smaug
https://hg.mozilla.org/integration/autoland/rev/ef8e38e743f2
part5 : activate a controller when its media enters fullscreen or picture-in-picture mode. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/97a24a095f23
part6 : notify change for fullscreen and picture-in-picture. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/000e442241d3
part7 : add test. r=chunmin
You need to log in before you can comment on or make changes to this bug.