1642786 - Improve UX of Push Health [meta]

Status: NEW

(Tree Management :: Push Health, enhancement, P1)

Description

[Cameron Dawson [:camd]]

During our UX study of Treeherder and Push health, we will make some incremental improvements to each. This bug will likely have several PRs as we iterate.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6480

Comment 2

[Cameron Dawson [:camd]]

This is a meta bug for just the Push Health changes.

Comment 3

[Sarah Clements [:sclements]]

I was looking back at my interview notes because KimberlyTheGeek is going to work on improving productivity for performance engineers, which means she might be making some changes to Perfherder.

I realized that something that I think we missed in our push health mockups is the inclusion of the performance data tab, which I think is how devs mostly get to that view (if I'm remembering correctly). At least two users used the compare view but I don't think we solicited feedback on the mockups from those two users (Tom.Prince and MattN). We should do so when we get ready for the soft launch. Maybe worth adding that in now and we can tweak it later once we get feedback. What do you think camd?

Comment 4

[Cameron Dawson [:camd]]

This is the performance data tab in the Task Details, right? As opposed to having a Perf tab be peer of Linting | Builds | Tests. I just wanted to be clear.

Yeah, that's a good idea. Do you have a feeling for if you'd rather have it be disabled or hidden if there is no perf data? Armen added the new Test Groups tab to the TH details panel, but has it disabled when not applicable. I was wondering if we should do that for the Perf tab as well (it's currently hidden).

Comment 5

[Sarah Clements [:sclements]]

(In reply to Cameron Dawson [:camd] from comment #4)

This is the performance data tab in the Task Details, right? As opposed to having a Perf tab be peer of Linting | Builds | Tests. I just wanted to be clear.

Yeah, exactly - just adding it as another tab along with artifacts and logviewer, the way it is in TH.

Yeah, that's a good idea. Do you have a feeling for if you'd rather have it be disabled or hidden if there is no perf data? Armen added the new Test Groups tab to the TH details panel, but has it disabled when not applicable. I was wondering if we should do that for the Perf tab as well (it's currently hidden).

I don't have a strong opinion on that. If it's disabled, perhaps adding a tooltip on hover stating "no performance tests were ran" or "no data to show" so people don't think something's broken. Not sure if that's how Armen has done it for Test Groups.

Comment 6

[Sarah Clements [:sclements]]

A recap of our meeting with Victoria today, our current approach for the "soft landing" will be to:

1. Finish implementing all features in the mockups, including the "my pushes" dashboard.
2. solicit feedback from our users, fix anything that needs to be fixed and ask if notifications (or any other features) would block them from switching to push health. One question we need to figure out is how much, if any, documentation or screencasts we should have prepared ahead of time. Maybe a small intro tour would suffice?
3. Make a PSA in slack or mailing lists about the new push health and the links in fabricator that will redirect to Push Health for try pushes. We'll include a banner that lets people get an easy out to TH if they don't have time to check out their revision on push health.

Comment 7

[Medequip]

Thanks for this.

https://medequip.co.in/