Closed Bug 1642863 Opened 1 month ago Closed 1 month ago

"[fluent] Missing translations in en-US: qualcomm" when opening about:support on Android device

Categories

(Toolkit :: General, defect)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox-esr68 --- wontfix
firefox76 --- wontfix
firefox77 --- wontfix
firefox78 --- fixed
firefox79 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [geckoview:m79])

Attachments

(1 file)

This call to buildRow is passing value directly, which is interpreted as a string ID, when in fact value should be passed verbatim.

value is not a string ID. On desktop this doesn't seem to matter because
value never passes the FLUENT_IDENT_REGEX test. OTOH, on Android it does.

Whiteboard: [geckoview:m79]
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c7bb28b23396
Ensure that value is passed into buildRow as array containing Text node; r=jaws
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79

The patch landed in nightly and beta is affected.
:aklotz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(aklotz)
Flags: needinfo?(aklotz)

Comment on attachment 9153711 [details]
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs

Beta/Release Uplift Approval Request

  • User impact if declined: Potential for missing data in about:support on mobile
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch
  • String changes made/needed:
Attachment #9153711 - Flags: approval-mozilla-beta?

Comment on attachment 9153711 [details]
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs

approved for 78.0b5

Attachment #9153711 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.