1642863 - "[fluent] Missing translations in en-US: qualcomm" when opening about:support on Android device

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

This call to buildRow is passing value directly, which is interpreted as a string ID, when in fact value should be passed verbatim.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs

value is not a string ID. On desktop this doesn't seem to matter because
value never passes the FLUENT_IDENT_REGEX test. OTOH, on Android it does.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7bb28b23396
Ensure that value is passed into buildRow as array containing Text node; r=jaws

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c7bb28b23396

Comment 4

[Release mgmt bot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:aklotz, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 9153711 [details]
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs

Beta/Release Uplift Approval Request

• User impact if declined: Potential for missing data in about:support on mobile
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 9153711 [details]
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs

approved for 78.0b5

Comment 7

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8ff9c7ca9dae