"[fluent] Missing translations in en-US: qualcomm" when opening about:support on Android device
Categories
(Toolkit :: General, defect)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [geckoview:m79])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
This call to buildRow
is passing value
directly, which is interpreted as a string ID, when in fact value
should be passed verbatim.
Assignee | ||
Comment 1•2 years ago
|
||
value
is not a string ID. On desktop this doesn't seem to matter because
value
never passes the FLUENT_IDENT_REGEX
test. OTOH, on Android it does.
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c7bb28b23396 Ensure that value is passed into buildRow as array containing Text node; r=jaws
Comment 3•2 years ago
|
||
bugherder |
Updated•2 years ago
|
Comment 4•2 years ago
|
||
The patch landed in nightly and beta is affected.
:aklotz, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
Comment on attachment 9153711 [details]
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs
Beta/Release Uplift Approval Request
- User impact if declined: Potential for missing data in about:support on mobile
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Trivial patch
- String changes made/needed:
Comment 6•2 years ago
|
||
Comment on attachment 9153711 [details]
Bug 1642863: Ensure that value is passed into buildRow as array containing Text node; r=jaws,gijs
approved for 78.0b5
Comment 7•2 years ago
|
||
bugherderuplift |
Updated•2 years ago
|
Description
•