1642885 - detect libc on BSD like on macosX

Status: RESOLVED FIXED

(Chat Core :: Security: OTR, defect)

Description

[Landry Breuil (:gaston)]

small oneliner to fix libc detection at runtime (seen errors in js console):

Index: comm/chat/modules/CLib.jsm
--- comm/chat/modules/CLib.jsm.orig
+++ comm/chat/modules/CLib.jsm
@@ -28,6 +28,7 @@ switch (OS) {
     fname_t = wchar_t.ptr;
     break;
   case "darwin":
+  case "openbsd":
     libcAbi = ctypes.default_abi;
     libcPath = ctypes.libraryName("c");
     break;

filing to see if there's interest in fixing this..

Comment 1

[Landry Breuil (:gaston)]

FreeBSD probably wants the same ?

Comment 2

[Patrick Cloke [:clokep]]

This looks fine to me, KaiE -- do you agree?

Comment 3

[Jan Beich]

Why not move libc under default case instead of enumerating every OS? I don't use Thunderbird.

See https://github.com/arlolra/ctypes-otr/commit/1917f769d656 for the old behavior.

Comment 4

[Kai Engert [:KaiE:]]

(In reply to Jan Beich from comment #3)

See https://github.com/arlolra/ctypes-otr/commit/1917f769d656 for the old behavior.

It's not clear what you want to demonstrate with this patch, which apparently refers to a revision that is two years older than the snapshot that we used as the base for porting over to TB.
If it's relevant, please explain.

Comment 5

[Kai Engert [:KaiE:]]

(In reply to Landry Breuil (:gaston) from comment #1)

FreeBSD probably wants the same ?

Here is code that checks for multiple variations of BSD. Should we map all those strings to the same as Darwin?
https://searchfox.org/comm-central/rev/771b2328aa3096e6c907f477d7ebd862c8bf0841/mozilla/build/gyp_includes/common.gypi#85

Comment 6

[Kai Engert [:KaiE:]]

Can someone make a patch with all the strings? Then I can r+ and commit.

Comment 7

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This adds the additional BSD systems, I debated adding a comment of where to look for this, but figured it wasn't worth it.

I tested this on macOS and it still worked without a problem, but don't have a(nother) BSD system to test on.

Comment 8

[Landry Breuil (:gaston)]

Comment on attachment 9154147 [details] [diff] [review]
Patch v1

That will work for us - thanks!

Comment 9

[Landry Breuil (:gaston)]

(In reply to Kai Engert (:KaiE:) from comment #4)

(In reply to Jan Beich from comment #3)

See https://github.com/arlolra/ctypes-otr/commit/1917f769d656 for the old behavior.

It's not clear what you want to demonstrate with this patch, which apparently refers to a revision that is two years older than the snapshot that we used as the base for porting over to TB.
If it's relevant, please explain.

i think jan meant to say 'before this commit, the default/fallback was working ootb on the BSDs'

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7b582eabc68
Detect libc for OTR on BSD. r=kaie

Comment 11

[Kai Engert [:KaiE:]]

Comment on attachment 9154147 [details] [diff] [review]
Patch v1

this should get into tb 78 for wider compatibility

Comment 12

[Wayne Mery (:wsmwk)]

Comment on attachment 9154147 [details] [diff] [review]
Patch v1

Approved for beta

Comment 13

[Geoff Lankow (:darktrojan)]

Thunderbird 78.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/c240eda98256

Comment 14

[Jakub Šebek]

The FreeBSD libc.so has been a linker script for 7 years prior to this change: https://cgit.freebsd.org/src/commit/?id=54f82841d5116d345fef2610dce38984c01a7ce1
It has to be linked directly:

case "freebsd":
  libcAbi = ctypes.default_abi;
  libcPath = "libc.so.7";
  break;

All the other BSDs should be correct.

Comment 15

[Patrick Cloke [:clokep]]

(In reply to Jakub Šebek from comment #14)

The FreeBSD libc.so has been a linker script for 7 years prior to this change: https://cgit.freebsd.org/src/commit/?id=54f82841d5116d345fef2610dce38984c01a7ce1

If this is not working properly on FreeBSD, please file a new bug so we can track this separately.

Comment 16

[Jakub Šebek]

(In reply to Patrick Cloke [:clokep] from comment #15)

(In reply to Jakub Šebek from comment #14)

The FreeBSD libc.so has been a linker script for 7 years prior to this change: https://cgit.freebsd.org/src/commit/?id=54f82841d5116d345fef2610dce38984c01a7ce1

If this is not working properly on FreeBSD, please file a new bug so we can track this separately.

Sure, Bug 1764118