Closed
Bug 1642943
Opened 4 years ago
Closed 4 years ago
Introduce a pref controlling post-facto dns resolution of single word hosts
Categories
(Firefox :: Address Bar, task, P2)
Firefox
Address Bar
Tracking
()
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
(Keywords: privacy)
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
When a single word that may be a valid intranet host is typed, we initially search for it, then fire a dns query to check if it may be a valid intranet host. If so we show a "did you mean to go to 'http://singleword/'" notification bar.
We should introduce an about:config pref to control this behavior.
Assignee | ||
Updated•4 years ago
|
Iteration: --- → 79.1 - June 1 - June 14
Points: --- → 2
Assignee | ||
Comment 1•4 years ago
|
||
Assignee | ||
Comment 2•4 years ago
|
||
this is temporarily on hold while we discuss and figure out things.
Assignee | ||
Updated•4 years ago
|
Summary: Introduce a pref for dns resolution of single word hosts, and avoid it in PB mode → Introduce a pref controlling post-facto dns resolution of single word hosts
Updated•4 years ago
|
Attachment #9154381 -
Attachment description: Bug 1642943 - Introduce a pref for dns resolution of single word hosts, and avoid it in PB mode → Bug 1642943 - Introduce a pref to control post-search DNS resolution of single word hosts. r=gijs,mkaply
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/f834e75495ed
Introduce a pref to control post-search DNS resolution of single word hosts. r=Gijs,mkaply
Comment 4•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Assignee | ||
Comment 5•4 years ago
|
||
Comment on attachment 9154381 [details]
Bug 1642943 - Introduce a pref to control post-search DNS resolution of single word hosts. r=gijs,mkaply
Beta/Release Uplift Approval Request
- User impact if declined: This is a something that recently came up in press as a privacy hit. We agree in some cases users may not want to disclose their search terms to the DNS, and we're discussing possible heuristics to limit the reach of it in bug 1642623. In the meanwhile, this bug introduces a pref that allows to disable the DNS lookup, and a policy for enterprise.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce: I think the automated test is good enough. Anyway STR may be:
- set browser.fixup.domainwhitelist.localhost and browser.fixup.domainsuffixwhitelist.localhost to false
- type localhost (without final slash, remove it if present) and Enter in the urlbar
- check the "did you mean to go to 'localhost'" prompt shows
- dismiss the prompt with the X, or the No Thanks button
- set browser.urlbar.dnsResolveSingleWordsAfterSearch to 0
- type localhost and Enter like at point 2
- check the prompt doesn't show
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is a simple disabling pref excluding a feature, defaults to the status-quo. The worst case of breakage would be that we don't show the "did you mean to go to site" prompt, that by itself doesn't break navigation or anything else (and indeed it was broken for months in the past without big consequences...).
- String changes made/needed:
Attachment #9154381 -
Flags: approval-mozilla-beta?
Comment 6•4 years ago
|
||
Comment on attachment 9154381 [details]
Bug 1642943 - Introduce a pref to control post-search DNS resolution of single word hosts. r=gijs,mkaply
approved for 78.0b7
Attachment #9154381 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 7•4 years ago
|
||
bugherder uplift |
status-firefox78:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•