1642999 - Ensure the search service xpcshell-tests have no console errors

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

When working on the tests and the search service, it is sometimes confusing when we get errors that are expected. This would be worse for new people working on the search service.

Therefore, we want to:

• Remove all existing errors where possible.
  • We could whitelist or stub-out some existing errors.
• Implement a way of preventing new errors being raised, e.g.
  • https://searchfox.org/mozilla-central/rev/8ccea36c4fb09412609fb738c722830d7098602b/browser/components/payments/test/browser/head.js#384
  • bug 1425305

Comment 1

[Mark Banner (:standard8)]

I took a look at the options here. I think bug 1425305 catches too much for what we want at the moment, and we'd need to do quite a bit of work integrating that in.

The payments option has given me something that I think is reasonable for us to base this on and at least catches any errors that are raised.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1642999 - Ensure the search service xpcshell-tests have no console errors. r?daleharvey!

Depends on D90293

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba0e6e83e0f8
Ensure the search service xpcshell-tests have no console errors. r=daleharvey

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ba0e6e83e0f8