164313 - why does the outer table frame not pass the selection to the caption.

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[Bernd]

the code at
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/nsTableOuterFrame.cpp#405
does not even mention a caption. I dont understand this. My feeling tells me it
should descend also into a table caption. May be this would be the fix for the
old editor bug that you can't enter text into a new created caption.  This has
to wait till Chris comes back to work, noone else at AIM??

Comment 1

[Bernd]

Attachment: testcase

press first the mouse down below the text in the green rectangle (the table
cell content) and drag.
second the mouse button down below the caption text (the orange rectangle) drag
and see what text is selected.

Comment 2

[Bernd]

Attachment: patch

The patch copies the layer parameter as we use them for blocks just two lines
below. The line was introduced by joki and I think the code was wrong because
below the caption the layer change made that the frames could not see the
event.

Comment 3

[Bernd]

*** Bug 174144 has been marked as a duplicate of this bug. ***

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 103509 [details] [diff] [review]
patch

r/sr=dbaron

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

nsLayoutAtoms::captionList,aWhichLayer, 

looks like a space is missing before aWhichLayer

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 103509 [details] [diff] [review]
patch

+    rv = GetFrameForPointUsing(aPresContext, aPoint,
nsLayoutAtoms::captionList,aWhichLayer,

Add a space before "aWhichLayer" and sr=bzbarsky

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 103509 [details] [diff] [review]
patch

a=dbaron for trunk checkin

Comment 8

[Bernd]

patch checked in into trunk