1643149 - [wayland] Firefox hangs when a second window is opened (with software rendering)

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P1)

Description

[dm]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Firefox/79.0

Steps to reproduce:

Open a new window.

Actual results:

Firefox stopped to respond to commands and sometimes there are rendering glitches.

I run mozregression first with a new profile and then with webrender enabled but nothing was wrong. I tried it with my usual profile and the problematic commit is this one: https://hg.mozilla.org/integration/autoland/rev/9b17e776c11765d83ef5f1b0a6288a0c688cd1e1.

Right I know I can't try other flags but I still want to help. What is the best way to share my config?

Comment 1

[dm]

I use sway on Arch Linux.

Comment 2

[dm]

Attachment: about:support dump (from a previous working build)

Comment 3

[dm]

I noticed that Webrender is now disabled by default, I enabled it with gfx.webrender.all=true and the issue now is gone. I also tried to disable/enable widget.wayland-dmabuf-vaapi.enabled and widget.wayland-dmabuf-webgl.enabled but they don't have any effect on the issue.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 5

[Darkspirit]

(In reply to d.masserut from comment #3)

I noticed that Webrender is now disabled by default, I enabled it with gfx.webrender.all=true and the issue now is gone.

0x5917 is whitelisted and WebRender is enabled by default on Nightly with Mesa 18+ if your screen size is at maximum 4953600 pixels.

What is your screen size?

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Thanks, I'll look at it asap.

Comment 7

[Kenny Levinsen :kennylevinsen]

Appears to just be an accidental inverted check in InhibitWaylandIdle.

bool WakeLockTopic::InhibitWaylandIdle() {
  // ...
  MozContainer* container = focusedWindow->GetMozContainer();
  wl_surface* waylandSurface = moz_container_wayland_surface_lock(container);
  /* The check below is wrong */
  if (!waylandSurface) {
    mWaylandInhibitor = zwp_idle_inhibit_manager_v1_create_inhibitor(
        waylandDisplay->GetIdleInhibitManager(), waylandSurface);
    moz_container_wayland_surface_unlock(container);
  }
  return true;
}

Comment 8

[Martin Stránský [:stransky] (ni? me)]

I see thanks. There's another bug in mozcontainer where the lock it's release.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1643149 [Wayland] Fix MozContainer deadlock, r?jhorak

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/827d6e47acfc
[Wayland] Fix MozContainer deadlock, r=jhorak

Comment 13

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/827d6e47acfc