1643162 - AttributeError: symbols_link_arg

Status: RESOLVED INVALID

(Firefox Build System :: General, defect, P3)

Description

[fabrixx2]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/82.0.4085.12 Safari/537.36

Steps to reproduce:

./mach build on Arch Linux Arctifact build

Actual results:

[fabrixx@archlinux firefox-77.0.1]$ ./mach build
0:00.40 Clobber not needed.
0:00.40 Adding make options from /home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/mozconfig
AUTOCLOBBER=1
MOZ_MAKE_FLAGS=-j4
MOZ_OBJDIR=/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/objdir-ffosS-release
OBJDIR=/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/objdir-ffosS-release
FOUND_MOZCONFIG=/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/mozconfig
export FOUND_MOZCONFIG
0:00.40 /usr/bin/make -f client.mk MOZ_PARALLEL_BUILD=4 -s
0:01.24 Error running mach:
0:01.24 ['--log-no-times', 'artifact', 'install']
0:01.24 The error occurred in code that was called by the mach command. This is either
0:01.24 a bug in the called code itself or in the way that mach is calling it.
0:01.24 You can invoke |./mach busted| to check if this issue is already on file. If it
0:01.24 isn't, please use |./mach busted file| to report it. If |./mach busted| is
0:01.24 misbehaving, you can also inspect the dependencies of bug 1543241.
0:01.24 If filing a bug, please include the full output of mach, including this error
0:01.24 message.
0:01.24 The details of the failure are as follows:
0:01.24 ValueError: Must provide path to exactly one of hg and git
0:01.24 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/artifact_commands.py", line 141, in artifact_install
0:01.24 artifacts = self._make_artifacts(tree=tree, job=job, skip_cache=skip_cache,
0:01.24 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/artifact_commands.py", line 109, in _make_artifacts
0:01.24 artifacts = Artifacts(tree, self.substs, self.defines, job,
0:01.24 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/artifacts.py", line 855, in init
0:01.24 raise ValueError("Must provide path to exactly one of hg and git")
0:01.26 make[3]: *** [Makefile:140: recurse_artifact] Errore 1
0:01.26 make[2]: *** [/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/config/recurse.mk:34: artifact] Errore 2
0:01.26 make[1]: *** [/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/config/rules.mk:394: default] Errore 2
0:01.27 make: *** [client.mk:125: build] Errore 2
0:01.29 0 compiler warnings present.
[fabrixx@archlinux firefox-77.0.1]$

Comment 1

[BugBot [:suhaib / :marco]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Mitchell Hentges [:mhentges] 🦀]

fabrixx2: How did you download the Firefox source code? I'm guessing that you downloaded the sourcecode as a tarball?
Also, do you have hg or git installed? My current theory about this error is that "artifact builds" require hg or git, but they aren't installed on your machine.

Comment 3

[Mitchell Hentges [:mhentges] 🦀]

Looking into this a bit more, I was able to reproduce this by:

1. Finding a Firefox source code tarball, I downloaded the one for 77.0.1
2. I created a mozconfig file with the parameters recommended here for artifact builds
3. ./mach build
   • Internally, ./mach artifact install is invoked, which balks if it's not run within a git or hg repository

If you perform a mach bootstrap, provide a location to clone the repository and do a build in the clone directory, it should work.
Please re-open this if I misunderstood the issue, or if performing a "clone" and building doesn't resolve the issue :)

Comment 4

[fabrixx2]

Ok was a tarball. if i don't use arctifact i have the error:

0:22.70 js/src> updating cache /home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/objdir-ffosS-release/./config.cache
0:22.70 js/src> creating ./config.data
0:22.71 js/src> Creating config.status
0:22.74 Creating config.status
0:22.91 Reticulating splines...
0:23.86 0:00.97 File already read. Skipping: /home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/gfx/angle/targets/angle_common/moz.build
0:27.14 Traceback (most recent call last):
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/configure.py", line 181, in <module>
0:27.14 sys.exit(main(sys.argv))
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/configure.py", line 57, in main
0:27.14 return config_status(config)
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/configure.py", line 176, in config_status
0:27.14 return config_status(args=[], **normalize(sanitized_config))
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/config_status.py", line 148, in config_status
0:27.14 the_backend.consume(definitions)
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/backend/base.py", line 130, in consume
0:27.14 if (not self.consume_object(obj) and
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/backend/recursivemake.py", line 619, in consume_object
0:27.14 self._process_shared_library(obj, backend_file)
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/backend/recursivemake.py", line 1279, in _process_shared_library
0:27.14 if libdef.symbols_link_arg:
0:27.14 AttributeError: symbols_link_arg
0:27.70 *** Fix above errors and then restart with
0:27.70 "./mach build"
0:27.71 make: *** [client.mk:115: configure] Errore 1

If i try with hg
After hg clone https://hg.mozilla.org/mozilla-central

I have:
0:22.66 js/src> checking for valloc in unistd.h... no
0:22.69 js/src> checking for _aligned_malloc in malloc.h... no
0:22.70 js/src> updating cache /home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/objdir-ffosS-release/./config.cache
0:22.70 js/src> creating ./config.data
0:22.71 js/src> Creating config.status
0:22.74 Creating config.status
0:22.91 Reticulating splines...
0:23.86 0:00.97 File already read. Skipping: /home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/gfx/angle/targets/angle_common/moz.build
0:27.14 Traceback (most recent call last):
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/configure.py", line 181, in <module>
0:27.14 sys.exit(main(sys.argv))
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/configure.py", line 57, in main
0:27.14 return config_status(config)
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/configure.py", line 176, in config_status
0:27.14 return config_status(args=[], **normalize(sanitized_config))
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/config_status.py", line 148, in config_status
0:27.14 the_backend.consume(definitions)
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/backend/base.py", line 130, in consume
0:27.14 if (not self.consume_object(obj) and
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/backend/recursivemake.py", line 619, in consume_object
0:27.14 self._process_shared_library(obj, backend_file)
0:27.14 File "/home/fabrixx/Scrivania/test/firefox-77.0.1.source/firefox-77.0.1/python/mozbuild/mozbuild/backend/recursivemake.py", line 1279, in _process_shared_library
0:27.14 if libdef.symbols_link_arg:
0:27.14 AttributeError: symbols_link_arg
0:27.70 *** Fix above errors and then restart with
0:27.70 "./mach build"
0:27.71 make: *** [client.mk:115: configure] Errore 1
[fabrixx@archlinux firefox-77.0.1]$ cd /home/fabrixx/Scrivania/test
[fabrixx@archlinux test]$ hg clone https://hg.mozilla.org/mozilla-central
734/5000
*** failed to import the firefoxtree extension from /home/fabrixx/.mozbuild/version-control-tools/hgext/firefoxtree: [Errno 2] No files or directories: '/home/fabrixx/.mozbuild/version - Control-tools / hgext / firefoxtree '
*** failed to import push-to-try extension from /home/fabrixx/.mozbuild/version-control-tools/hgext/push-to-try: [Errno 2] No files or directories: '/ home / fabrixx / .mozbuild / version-control-tools / hgext / push-to-try '
target directory: mozilla-central
clone package application from https://hg.cdn.mozilla.net/mozilla-central/66d3efe9fc7a276ba284bb1f98a4e9c3cc53e1fb.zstd-max.hg
I'm adding changesets
I'm adding the manifest
I'm adding changes to the files

it is the first time i have this error, i have compiled all nightly versions of firefox from 64 without problems. That's why I had tried the tarball

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Hmm, that's weird. It might be worth trying ./mach bootstrap, then building again. That will ensure that new dependencies that are needed are downloaded.

Would you mind running bootstrap, then (if the build is still failing) performing a ./mach build -v and posting the output?

Comment 6

[fabrixx2]

sto aggiungendo i changeset
sto aggiungendo i manifesti
sto aggiungendo le modifiche ai file
transazione abortita!
rollback completato
abortito: Connection reset by peer
[fabrixx@archlinux DATI]$

every time Connection reset by peer-

Left opened for hours

Comment 7

[Mitchell Hentges [:mhentges] 🦀]

What command was being run when you got that output?

Comment 8

[fabrixx2]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #7)

What command was being run when you got that output?

hg clone https://hg.mozilla.org/releases/mozilla-release/

or

hg clone https://hg.mozilla.org/mozilla-central

in every case stands still on

[fabrixx@archlinux DATI]$ hg clone https://hg.mozilla.org/releases/mozilla-release/
directory di destinazione: mozilla-release
applying clone bundle from https://hg.cdn.mozilla.net/releases/mozilla-release/51c7d1ebabd37870b4033608576e4829b6d1ccdf.zstd.hg
adding changesets [ .....3 min ok]
adding manifests [.....5 min]
adding changes to the files [.....30 min ok]
still blocked for 40m/1hour

Connection reset by peer

I have tried at least 8 times in the last 3 days always the same problem, never occurred in the past few months

Comment 9

[fabrixx2]

Attachment: bbbb.png

Comment 10

[fabrixx2]

Attachment: aaaa.png

Comment 11

[Mitchell Hentges [:mhentges] 🦀]

You are having some bad luck today, that looks like another (unrelated) issue.
I've created a bugzilla ticket over here to represent that hg clone issue.

I'm going to rename this ticket back to its original title, so we can resolve this once your hg clone is working again.

Comment 12

[fabrixx2]

Similar to this:
https://bugzilla.mozilla.org/show_bug.cgi?id=1614852

Comment 13

[fabrixx2]

also today same error upload image

Comment 14

[fabrixx2]

Attachment: aaaz.png

Comment 15

[Mitchell Hentges [:mhentges] 🦀]

Yeah, that bug looks similar too. I'm not too familiar with the internals of hg clone, so I think the right thing to do is to wait until Connor replies to that bug I created to represent the hg clone issue you're seeing.

Comment 16

[fabrixx2]

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #15)

Yeah, that bug looks similar too. I'm not too familiar with the internals of hg clone, so I think the right thing to do is to wait until Connor replies to that bug I created to represent the hg clone issue you're seeing.

You can try to download zip from here (link on top)
https://hg.mozilla.org/mozilla-central/

Central or another..

Central worked for me.

Comment 17

[fabrixx2]

(In reply to fabrixx2 from comment #16)

(In reply to Mitchell Hentges [:mhentges] 🦀 from comment #15)

Yeah, that bug looks similar too. I'm not too familiar with the internals of hg clone, so I think the right thing to do is to wait until Connor replies to that bug I created to represent the hg clone issue you're seeing.

You can try to download zip from here (link on top)
https://hg.mozilla.org/mozilla-central/

Central or another..

Central worked for me.

But Im una le to use arctifact. Compiled in standard mode..

Comment 18

[Mitchell Hentges [:mhentges] 🦀]

I've created that separate bug and called in Connor because I don't know how you're seeing that hg clone issue.
I'm unable to reproduce this problem. If I hg clone https://hg.mozilla.org/releases/mozilla-release, it completes successfully.
There's something funky going on that's specific to your environment - computer, network, perhaps the "mirror" that hg is downloading from.

I'm able to help with the ./mach issues, but Connor has much more necessary knowledge with hg and our servers to help determine why it fails when you hg clone.

Comment 19

[fabrixx2]

Thank you.
I am approaching the monthly data threshold of my network provider I can no longer try again

Comment 21

[fabrixx2]

I compiled mozilla central with arctifact build today and everything went well.

I also noticed a novelty I didn't remember before: the request to confirm the installation folder of the build files.

For me is fixed.

Comment 22

[Mitchell Hentges [:mhentges] 🦀]

Sounds good, I'll close this ticket, but re-open it if you run into that symbols_link_arg issue again :)