Closed
Bug 1643289
Opened 2 years ago
Closed 2 years ago
nsTPriorityQueue should make better use of move semantics
Categories
(Core :: XPCOM, task)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla79
| Tracking | Status | |
|---|---|---|
| firefox79 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(2 files)
nsTPriorityQueue is unnecessarily copyable (it is only copied in tests), and also unnecessarily copies its elements when they could be moved.
|
Assignee | |
Comment 1•2 years ago
|
||
Depends on D78027
|
||
Updated•2 years ago
|
Assignee: nobody → sgiesecke
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Also remove redundant check in Push method on result of infallible operation,
and change its return type to void.
Depends on D78248
|
|
||
Updated•2 years ago
|
Attachment #9154131 -
Attachment description: Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r-froydnj → Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them.
|
|
||
Updated•2 years ago
|
Attachment #9154131 -
Attachment description: Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. → Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r-froydnj
|
|
||
Updated•2 years ago
|
Attachment #9154131 -
Attachment description: Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r-froydnj → Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9447ea8910aa Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj https://hg.mozilla.org/integration/autoland/rev/98c420f73380 Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj
|
||
Comment 4•2 years ago
|
||
Backed out for causing failure at test_headless_screenshot.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/0ca9f1ff7aacca2aed2a74a4c6743a02eed9917f
Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305754090&repo=autoland&lineNumber=1408
Flags: needinfo?(sgiesecke)
|
|
Assignee | |
Updated•2 years ago
|
Flags: needinfo?(sgiesecke)
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3b3ffcc8be7 Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj https://hg.mozilla.org/integration/autoland/rev/f8faae6114e0 Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj
|
||
Comment 6•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a3b3ffcc8be7
https://hg.mozilla.org/mozilla-central/rev/f8faae6114e0
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in
before you can comment on or make changes to this bug.
Description
•