1643289 - nsTPriorityQueue should make better use of move semantics

Status: RESOLVED FIXED

(Core :: XPCOM, task)

Description

[Simon Giesecke [:sg] [he/him]]

nsTPriorityQueue is unnecessarily copyable (it is only copied in tests), and also unnecessarily copies its elements when they could be moved.

Comment 1

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1643289 - Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj

Depends on D78027

Comment 2

[Simon Giesecke [:sg] [he/him]]

Attachment: Bug 1643289 - Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj

Also remove redundant check in Push method on result of infallible operation,
and change its return type to void.

Depends on D78248

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9447ea8910aa
Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/98c420f73380
Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj

Comment 4

[Atila Butkovits]

Backed out for causing failure at test_headless_screenshot.html.

Backout link: https://hg.mozilla.org/integration/autoland/rev/0ca9f1ff7aacca2aed2a74a4c6743a02eed9917f

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=98c420f7338066f5e4fe35fbce9905911e895efd&selectedTaskRun=V3VbtT7VRv6OzmxesaPA_w-0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305754090&repo=autoland&lineNumber=1408

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3b3ffcc8be7
Make nsTPriorityQueue non-copyable and remove use of CopyableTArray. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/f8faae6114e0
Move elements where possible in nsTPriorityQueue instead of copying them. r=froydnj

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/a3b3ffcc8be7
https://hg.mozilla.org/mozilla-central/rev/f8faae6114e0