1643298 - No mozconfig information is outputted after running `mach bootstrap --no-system-changes`

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

I see that the document says:

Once mach bootstrap is complete it will tell you to copy and paste some configuration into your mozconfig file. The mozconfig file can be found in the root of your gecko repo - or create a file called mozconfig if it does not exist. Check that the correct value is associated with the --target argument as this may not correctly match your setup. Copy the file contents from the mach bootstrap output into your file and save in the root directory of your project.

But I see no mozconfig after running it with GeckoView/Firefox for Android chosen.

Note that I do have several other mozconfig files in the directory for desktop configuration, but it shouldn't affect it.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

When looking at the code, I found there are several functions named suggest_mobile_android_mozconfig around, but I can find no entry point of these functions.

Comment 2

[Ricky Stewart]

On my machine I get this output after mach bootstrap:

Paste the lines between the chevrons (>>> and <<<) into your
$topsrcdir/mozconfig file, or create the file if it does not exist:

>>>
# Build GeckoView/Firefox for Android:
ac_add_options --enable-application=mobile/android

# Targeting the following architecture.
# For regular phones, no --target is needed.
# For x86 emulators (and x86 devices, which are uncommon):
# ac_add_options --target=i686
# For newer phones.
# ac_add_options --target=aarch64
# For x86_64 emulators (and x86_64 devices, which are even less common):
# ac_add_options --target=x86_64
<<<

Are you not seeing this?

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

I was not seeing that. And I tried it again this morning and it seems to work beyond what I previous see and I can see that it's on its way to this message since it started downloading Android stuff which I didn't see before.

I think this is probably related to --no-system-changes I passed to mach bootstrap yesterday. And I believe I had to pass this because of node version, which Ubuntu has 10.19, but building Firefox requires 10.21, so mach build or so asked me to pass --no-system-changes to work around.

Comment 4

[Ricky Stewart]

You're right; when no-system-changes is set, we onboard onto a smaller, bespoke codepath that doesn't invoke that code.

Comment 5

[Mitchell Hentges [:mhentges] 🦀]

Attachment: Bug 1643298: |mach bootstrap --no-system-changes| should still output mozconfig r?rstewart

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5595d6b0dedd
|mach bootstrap --no-system-changes| should still output mozconfig r=rstewart,geckoview-reviewers,agi

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5595d6b0dedd