1643340 - Can't submit feedback or comment with pending review requests in Splinter Review

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Cancel dialog

In the last week, I've received feedback requests via Bugzilla (not Phabricator), and the system seems quite broken.

I had a f? on myself, but the r? for the patch was set to another person.

After clicking the Splinter Review, I could not submit my f+, because Bugzilla would warn me that You must provide a reviewer for review requests.. I couldn't even comment for the same reason.

Note that the name of the reviewer set for r? was not visible in the UI, there was no field next to the dropdown.

On top of that, pressing Cancel shows a dialog that it's not readable with the dark theme, and pressing Cancel only empties the comment area (I would expect it to close the review).

Comment 1

[Thomas D. (:thomas8)]

Much of Thunderbird's review process is now broken because of this.

Essentially, this makes reviews entirely impossible (maybe depending on scenario).
Scenario which failed here is same as reporter's: Someone set review?personA and feedback?personB. When starting review (as personB), only question marks shown, names of people requested from missing. After spending much time and effort on detailed review, when trying to publish the (feedback) review, it fails with Error message "You must provide a reviewer for review requests". Then I believe even the entire review was already down the drain without recovery. This is bad as it disturbs our development processes :-/

Can someone please set priority and look into this ASAP! Tia.

Comment 2

[David Lawrence [:dkl]]

The fix for this should be live. Please let me know if not the case.