1643343 - The OpenPGP key details dialog doesn't properly adjust its size after enabling elements

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect, P1)

Description

[Kai Engert [:KaiE:]]

mail/extensions/openpgp/content/ui/keyDetailsDlg.xhtml
mail/extensions/openpgp/content/ui/keyDetailsDlg.js

The dialog has optional elements, such as a list of alternative IDs.
I regularly saw the dialog opening wits its lower area cut off, and the OK button not being visible.

How can we properly resize its contents?
I'd appreciate help or a patch, thanks in advance.

If you need a test key with alternative user IDs, you may use mine:
https://kuix.de/pgpkey.txt

Comment 1

[Kai Engert [:KaiE:]]

Alessandro, this might an important issue.
Do you have an idea how to fix it?

Comment 2

[Kai Engert [:KaiE:]]

I see my key isn't the best to reproduce it. But you could use the following, which has multiple IDs:
CBCD8F030588653EEDD7E2659B7DD433F254904A
(Use OpenPGP key manager, keyserver, discover online, and past this fingerprint.)

Comment 3

[Alessandro Castellani [:aleca]]

The dialog should resize to accommodate all the elements, and if the sum of the elements is taller than the available window, a scrollbar should appear.
I'll take a look at this, thanks for providing the test keys.

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: 1643343-openpgp-dialog.diff

This takes care of properly resizing the dialog when the data changes.
I also updated the style of that section to make it look consistent and more digestible.

Comment 5

[Kai Engert [:KaiE:]]

Comment on attachment 9168898 [details] [diff] [review]
1643343-openpgp-dialog.diff

Thank you, works great!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/865f2cebb8f1
Fix the OpenPGP Key details dialog not resizing to fit all available elements. r=KaiE DONTBUILD

Comment 7

[Kai Engert [:KaiE:]]

Comment on attachment 9168898 [details] [diff] [review]
1643343-openpgp-dialog.diff

OpenPGP UI correctness, no risk

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9168898 [details] [diff] [review]
1643343-openpgp-dialog.diff

[Triage Comment]
Approved for beta

Approved for esr78

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 80.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/2a43d108123d

Comment 10

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/releases/comm-esr78/rev/d45cbd67f0767ec936eca772ac89627ab6ffff9e