Closed Bug 1643438 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23994 - WebXR - mojo - rename XRReferenceSpaceCategory to XRReferenceSpaceType

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox79 fixed)

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23994 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23994
Details from upstream follow.

Piotr Bialecki <bialpio@chromium.org> wrote:

WebXR - mojo - rename XRReferenceSpaceCategory to XRReferenceSpaceType

This is a mechanical change to rename the mojo type and additional misc
changes requested as a followup for CL https://crrev.com/c/2203277.

Changes:

  • s/XRReferenceSpaceCategory/XRReferenceSpaceType, along with renaming
    few variable names from "*category" to "*type"
  • changed mojo type from now-deprecated macro-style naming to
    constant-style naming
  • refactored few lines of code that compute reference space appropriate
    for anchor creation into XRSession::GetStationaryReferenceSpace(), used
    both in XRFrame and in XRHitTestResult for anchor creation
  • added using in xr_reference_space.cc to help with readability of a
    quite-long type to something shorter (ReferenceSpaceType instead of
    device::mojom::blink::XRReferenceSpaceType) - same directive could be
    introduced in other files but the occurrences of the offending type are
    not that common elsewhere
  • refactored XRReferenceSpace::NativeFromMojo() since 3 cases were
    identical or very similar

There should be no functional change.

Change-Id: I8e8efdc036f11347f8d9159fbaede44634c6eb78
Reviewed-on: https://chromium-review.googlesource.com/2229622
WPT-Export-Revision: 8263858f1c5046d80a7a955e4ef0b34ac8fbe924

Test result changes from PR not available.
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/57abf888d008
[wpt PR 23994] - WebXR - mojo - rename XRReferenceSpaceCategory to XRReferenceSpaceType, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.