Closed Bug 1643465 Opened 4 years ago Closed 4 years ago

browser/base/content/test/about/browser_aboutCertError.js has high level of intermittents

Categories

(Firefox :: Security, defect)

defect

Tracking

()

RESOLVED FIXED
Firefox 79
Tracking Status
firefox79 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file, 1 obsolete file)

Landing of bug 1631593 made bug 1614049 more frequent.

See Also: → 1614049
Assignee: nobody → gandalf
Status: NEW → ASSIGNED

I tried to reproduce it locally in debug build with ./mach test browser/base/content/test/about/browser_aboutCertError.js --verify so I suspect it's a race condition that my CPU is too fast for and treeherder is slow enough to get.

The stateless L10n patch probably made it easier to reproduce, but not easy enough for me yet :(

I'm getting certain that this test needs some love, it may be that it's racy and / or it may be that it just too slow.

As I said, I couldn't reproduce any failure in the --verify mode locally, but I slowed down my CPU to 800Mhz and run the ./mach test browser/base/content/test/about/browser_aboutCertError.js --verify` again in the debug mode and got one failure:

mochitest-browser
~~~~~~~~~~~~~~~~~
Ran 2269 checks (2242 subtests, 27 tests)
Expected results: 2268
Unexpected results: 1
  subtest: 1 (1 fail)

Unexpected Results
------------------
browser/base/content/test/about/browser_aboutCertError.js
  FAIL This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N), but only as a last resort. -

which matches bug 1631134 and bug 1283511 both of which were reported and resolved as incomplete due to inactivity.

I think bug 1631593 may make it easier to debug this test, but since I can't reproduce it locally easily and I don't know this code, I may not be the best person to fix it.

On the other hand, since my code made this intermittent more visible and led to disabling of the test, I'd like to participate in help in restoring the test.

NI'in :johannh and :prathiksha for feedback and help in getting this test back in action.

Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(jhofmann)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/e5cca411b095
skip browser_aboutCertError.js on Linux debug with fission. r=johannh-on-matrix
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(jhofmann)
Attachment #9154328 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: