[wpt-sync] Sync PR 24000 - Revert "[WebSocket] Test header + close frame in same packet"
Categories
(Core :: Networking: WebSockets, task, P4)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 24000 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/24000
Details from upstream follow.
Jonathan Ross <jonross@chromium.org> wrote:
Revert "[WebSocket] Test header + close frame in same packet"
This reverts commit 3be4a6e9fbba0ce3e593d856a4b3d98f977aa279.
Reason for revert: Updated test is flaking on all platforms. crbug.com/1091377
Original change's description:
[WebSocket] Test header + close frame in same packet
Modify the existing web platform test opening-handshake/005.html to send
the response header and the close frame in the same packet. This
verifies that Chrome passes the close data to JavaScript correctly in
this case.This increases the coverage of the existing test, so there's no need to
retain the old behaviour.Also remove the timeout expectations for this test, and make sure it
doesn't timeout on failure.Closed: 1090210
Change-Id: I327c55d1517615511d6d71e1b464d5d3dc03b502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228252
Commit-Queue: Adam Rice \<ricea@chromium.org>
Reviewed-by: Yutaka Hirano \<yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775124}TBR=ricea@chromium.org,yhirano@chromium.org
Change-Id: I729663e5d0f7f6e41304b67c135b9af8946e503e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231268
Reviewed-by: Jonathan Ross \<jonross@chromium.org>
Commit-Queue: Jonathan Ross \<jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775233}
Assignee | ||
Comment 1•4 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=090eee3b641057eca6ff30bf945e67d450e595dd
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 2•4 years ago
|
||
CI Results
Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 2 tests and 1 subtests
Status Summary
Firefox
OK : 2
PASS: 2
Chrome
OK : 2
PASS: 2
Safari
OK : 2
PASS: 2
Links
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d12e2d5ea882 [wpt PR 24000] - Revert "[WebSocket] Test header + close frame in same packet", a=testonly
Comment 4•4 years ago
|
||
bugherder |
Description
•