1643499 - FirstStartup fails to complete Normandy initialization

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Punam Dahiya [:pdahiya]]

FirstStartup.jsm Normandy initialization exits early when launched using

./mach run --temp-profile --first-startup -- "about:welcome"

Debugging the issue, regression seems to be caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1643079

where we are now checking state and returning early https://searchfox.org/mozilla-central/source/toolkit/components/normandy/Normandy.jsm#56

Looks like Normandy.init() from BrowserGlue kicks in first setting Normandy to queued state causing FirstStartUp Normandy initialization to exit early

Comment 1

[Punam Dahiya [:pdahiya]]

NI Mythmon to look into the issue and help as this blocks testing multistage onboarding experiment in dev. Thanks!

Comment 2

[Michael Cooper [:mythmon]]

Seems like we should probably back out bug 1643079. The fix it provides it lower priority than this.

Comment 3

[Robert Helmer [:rhelmer]]

(In reply to Michael Cooper [:mythmon] from comment #2)

Seems like we should probably back out bug 1643079. The fix it provides it lower priority than this.

+1, let's also add a test that catches this before re-landing (at least as much as we can reasonably test, I know the interaction here is complex)

Comment 4

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1643079

Comment 5

[Michael Cooper [:mythmon]]

Bug 1643079 has been backed out, so this problem should be fixed now. I'll add notes to the other bug to make sure we don't regress this again.

Comment 6

[Punam Dahiya [:pdahiya]]

Thanks @mythmon!