Closed Bug 1643607 Opened 8 months ago Closed 7 months ago

Re-enable browser/base/content/test/about/browser_aboutCertError.js for Fission Linux debug

Categories

(Firefox :: Security, defect, P5)

Unspecified
Linux
defect

Tracking

()

RESOLVED FIXED
Firefox 79
Fission Milestone Future
Tracking Status
firefox79 --- fixed

People

(Reporter: zbraniecki, Assigned: timhuang)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1643465 +++

In bug 1643465 we disabled browser_aboutCertError.js because bug 1631593 made bug 1614049 much more reproducible.

I'd like to help re-enable this test ASAP.

How can I help here? What's the right way to debug this timeout - we know that fission/lazy-l10n impacts it and I cannot reproduce it locally so I suspect race.

Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(jhofmann)

Fission test failures are a blocker for enabling Fission in Nightly. Tracking this test failure for Fission milestone M4.1.

Fission Milestone: --- → M4.1

Ethan, we need a security engineer to help debug a timeout in this cert error test on Fission Linux. This is a blocker for enabling Fission in Nightly.

This test is disabled only for debug Fission Linux:

https://searchfox.org/mozilla-central/rev/0e09b9191c02097034e46b193930f91c45b7885d/browser/base/content/test/about/browser.ini#12-13

[browser_aboutCertError.js]
skip-if = fission && os == "linux" && debug # bug 1643465
Flags: needinfo?(ettseng)
OS: Unspecified → Linux
Summary: Re-enable browser/base/content/test/about/browser_aboutCertError.js → Re-enable browser/base/content/test/about/browser_aboutCertError.js for Fission Linux

Our team does not have time to look into this arguably low-impact failure at the moment, so I suggest keeping it disabled permanently, with this bug for tracking.

Flags: needinfo?(prathikshaprasadsuman)
Flags: needinfo?(jhofmann)
Flags: needinfo?(ettseng)
Severity: -- → S4
Priority: -- → P5

(In reply to Johann Hofmann [:johannh] from comment #3)

Or team does not have time to look into this arguably low-impact failure at the moment, so I suggest keeping it disabled permanently, with this bug for tracking.

Good to know. In that case, I'll mark this bug as not blocking Fission. :)

Fission Milestone: M4.1 → Future
Summary: Re-enable browser/base/content/test/about/browser_aboutCertError.js for Fission Linux → Re-enable browser/base/content/test/about/browser_aboutCertError.js for Fission Linux debug

That seems fine, thanks!

Assignee: nobody → tihuang
Status: NEW → ASSIGNED

I figured out that the element we get here could be different from the one that really displays in the error page. So, the element won't be updated with the translated text, so the test stops there.

I suspect that the L10n would create a new element and the test code cache the old element. So, the old element doesn't get the text. Then, the test code won't know that the text is indeed updated. But, I am not sure about this since I am not familiar with how L10n works. But, I think we can still fix this without knowing that. We can simply get the element every time the test code wants to check the condition of the element.

Yes. That's one of the shortcomings of the current l10n overlay system - we break element identity when retranslating. See https://github.com/projectfluent/fluent.js/wiki/DOM-Overlays#limitations

The timeout happens when we get an old element of the 'errorCode'
element in the test code. In this patch, we fix this issue by getting
the element every time we check the condition of the 'errorCode'
condition.

Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ce45f7273cc0
Fix the timeout issue of the test browser_aboutCertError.js in Fission. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
See Also: → 1675420
You need to log in before you can comment on or make changes to this bug.