1643672 - permafail - comm/mail/components/extensions/test/browser/browser_ext_menus.js | Test timed out -

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: mkmelin+mozilla [at] iki.fi
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=305188376&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/KTfGO6LXTQ-kFVsd5WD9jA/runs/0/artifacts/public/logs/live_backing.log

---

In the log I see

[JavaScript Error: "can't access property "matches", extension.whiteListedHosts is undefined" {file: "chrome://messenger/content/parent/ext-menus.js" line: 1065}]

Comment 1

[Magnus Melin [:mkmelin]]

Assuming m-c, something from https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=fecffba489bd447d60c2930f9d55ef834b1b20da

Comment 2

[Magnus Melin [:mkmelin]]

From bug 1642956 - https://hg.mozilla.org/mozilla-central/rev/be169dd8e469

Comment 3

[Magnus Melin [:mkmelin]]

Just changing to
(contextUrl && extension.allowedOrigins.matches(contextUrl));

... doesn't appear to help though :/
Maybe there's something else too.

Comment 4

[Magnus Melin [:mkmelin]]

Hmm, built with m-c 604cf003782d and c-c c79bee7bdfcf and the test still fails.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/af114f33be84
Fix browser_ext_menus.js to work by itself again. rs=bustage-fix
https://hg.mozilla.org/comm-central/rev/46ca821ece1d
Port bug 1642956 - Rename extension.whiteListedHosts to allowedOrigins. rs=bustage-fix

Comment 6

[Geoff Lankow (:darktrojan)]

The test wasn't working by itself even at earlier points. Some of the earlier tests in that folder have done enough to stop it failing (that is, opening the folder tree part of the 3-pane window). Once the test ran by itself the fix was a simple rename of a property.

Comment 7

[Magnus Melin [:mkmelin]]

Thanks!

Comment 8

[Intermittent Failures Robot]

48 failures in 4949 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #35 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 48

Platform breakdown:

• windows10-64: 6
• macosx1014-64: 6
• windows7-32: 6
• linux64: 6
• windows7-32-shippable: 6
• windows10-64-shippable: 6
• linux64-shippable: 6
• macosx1014-64-shippable: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1643672&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 9

[Geoff Lankow (:darktrojan)]

Attachment: 1643672-test-standalone.diff

[Approval Request Comment]
Just a fix to make a test run by itself without the other tests in the directory. Requesting uplift approval so that subsequent changes to this test apply cleanly. This landed in 79.

Comment 10

[Rob Lemley [:rjl]]

Comment on attachment 9187955 [details] [diff] [review]
1643672-test-standalone.diff

[Triage Comment]
Only changes test code, no user impact.

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.5.0:
https://hg.mozilla.org/releases/comm-esr78/rev/6717d335976d