1643687 - Search bar becomes unresponsive if using paste and go context menu option with a string while search tip is displayed

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: adress_bar_0.gif

Affected versions

• 78.0b3 (20200604213430)
• 79.0a1 (20200604220012)

Affected platforms

• macOS 10.12
• Windows 10x64

Steps to reproduce

1. Open Firefox and about:config and set devtools.chrome.enabled:true.
2. Open browser console and type (async function() { let { ProfileAge } = ChromeUtils.import("resource://gre/modules/ProfileAge.jsm"); let age = await ProfileAge(); age._times = { firstUse: 1368255600000, created: 1368255600000 }; await age.writeTimes(); })();.
3. Restart the browser and copy a random string in the clipboard (e.g firefox).
4. Open a new tab and select Paste and go from the context menu option into the address bar.

Expected result

• The copied string is successfully pasted and searched.

Actual result

• Nothing happens. Nightly shows this error in console/ Beta shows this error in console.

Regression range

• Firefox 77.0.1 (20200602222727) is not affected. I tried searching for one but I don’t know how to trigger the search tip in mozregression. It seems that it doesn't work by following the above steps. I will search for one manually ASAP.

Notes

• Attached a screen recording with the issue.

Comment 1

[Marco Bonardo [:mak]]

maybe related to my changes in bug 1636583, there may be unexpected handling of tips?

Comment 2

[Harry Twyford]

This can be reproduced when using the search tips "cheat" pref, setting browser.urlbar.searchTips.test.ignoreShowLimits to true.

Comment 3

[Alexandru Trif, Desktop Test Engineering [:atrif]]

(In reply to Harry Twyford [:harry] from comment #2)

This can be reproduced when using the search tips "cheat" pref, setting browser.urlbar.searchTips.test.ignoreShowLimits to true.

Confirming the regression range with mozregression. Thank you!

Last good revision: 8f6fbfc7558c71bf283696578d148389fc7c2392
First bad revision: 3883a1bffcbee3c00df6c0388c16b86d707e36ec
Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8f6fbfc7558c71bf283696578d148389fc7c2392&tochange=3883a1bffcbee3c00df6c0388c16b86d707e36ec

Comment 4

[Harry Twyford]

Attachment: Bug 1643687 - Resolve incompatibility between Search Tips and Paste & Go. r?mak

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89dc62c137a1
Resolve incompatibility between Search Tips and Paste & Go. r=mak

Comment 6

[Harry Twyford]

Comment on attachment 9156266 [details]
Bug 1643687 - Resolve incompatibility between Search Tips and Paste & Go. r?mak

Beta/Release Uplift Approval Request

• User impact if declined: Users being shown Search Tips might be able to break the address bar. Search Tips are shown mostly to new profiles. Also Search Tips are launching on ESR for the first time in 78.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0 and comment 2.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is targeted specifically towards Urlbar Tips, which are shown in pretty limited circumstances. This fix wouldn't be able to break any other part of the Urlbar.
• String changes made/needed:

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/89dc62c137a1

Comment 8

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 79.0a1 (20200614215300) on Windows 10x64, macOS 10.12 and Ubuntu 18.04. The search bar works as expected when using Paste and Go context menu option while search tip is displayed.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9156266 [details]
Bug 1643687 - Resolve incompatibility between Search Tips and Paste & Go. r?mak

approved for 78.0b8

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/04b57a2b3df5

Comment 11

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified using Firefox 78.0b8 (20200615143809) from comment 10 on Windows 10x64, macOS 10.12 and Ubuntu 18.04