Fix v8::Address / js::jit::Address confusion in unified builds
Categories
(Core :: JavaScript Engine, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox79 | --- | fixed |
People
(Reporter: iain, Assigned: iain)
Details
Attachments
(2 files)
Assignee | ||
Comment 1•5 years ago
|
||
RegExpNativeMacroAssembler.cpp has a list of using js::jit::X
statements to keep the code readable. Depending on the config options and the whims of the unified build, using js::jit::Address
can appear in imported V8 files where we actually want v8::Address
.
The easy fix is to build RegExpNativeMacroAssembler separately.
Comment 3•5 years ago
|
||
Backed out for bustages on regexp-bytecodes.cc
Backout link: https://hg.mozilla.org/integration/autoland/rev/56cc12211adf546d4fdb7505399b62a1b33f7361
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305227045&repo=autoland&lineNumber=1334
Assignee | ||
Comment 4•5 years ago
|
||
The fickle, ever-changing whims of unified builds shuffled code around enough that the place where we are printing this value inlined this function and complained about the unique_ptr being null. We continue to not care about this output, so instead of messing around with copying the characters we just return an empty string.
Assignee | ||
Updated•5 years ago
|
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/969dfa0cd82e
https://hg.mozilla.org/mozilla-central/rev/777fe18afe35
Description
•