1643700 - Fix v8::Address / js::jit::Address confusion in unified builds

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1643700: Fix v8::Address / js::jit::Address confusion r=lth

RegExpNativeMacroAssembler.cpp has a list of using js::jit::X statements to keep the code readable. Depending on the config options and the whims of the unified build, using js::jit::Address can appear in imported V8 files where we actually want v8::Address.

The easy fix is to build RegExpNativeMacroAssembler separately.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab35272d8c4
Fix v8::Address / js::jit::Address confusion r=lth

Comment 3

[Narcis Beleuzu [:NarcisB]]

Backed out for bustages on regexp-bytecodes.cc

Backout link: https://hg.mozilla.org/integration/autoland/rev/56cc12211adf546d4fdb7505399b62a1b33f7361
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=305227045&repo=autoland&lineNumber=1334

Comment 4

[Iain Ireland [:iain]]

Attachment: Bug 1643700: Fix ToCString r=mgaudet

The fickle, ever-changing whims of unified builds shuffled code around enough that the place where we are printing this value inlined this function and complained about the unique_ptr being null. We continue to not care about this output, so instead of messing around with copying the characters we just return an empty string.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/969dfa0cd82e
Fix v8::Address / js::jit::Address confusion r=lth
https://hg.mozilla.org/integration/autoland/rev/777fe18afe35
Fix ToCString r=mgaudet

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/969dfa0cd82e
https://hg.mozilla.org/mozilla-central/rev/777fe18afe35