Closed Bug 1643700 Opened 1 month ago Closed 1 month ago

Fix v8::Address / js::jit::Address confusion in unified builds

Categories

(Core :: JavaScript Engine, task)

task

Tracking

()

RESOLVED FIXED
mozilla79
Tracking Status
firefox79 --- fixed

People

(Reporter: iain, Assigned: iain)

Details

Attachments

(2 files)

No description provided.

RegExpNativeMacroAssembler.cpp has a list of using js::jit::X statements to keep the code readable. Depending on the config options and the whims of the unified build, using js::jit::Address can appear in imported V8 files where we actually want v8::Address.

The easy fix is to build RegExpNativeMacroAssembler separately.

Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2ab35272d8c4
Fix v8::Address / js::jit::Address confusion r=lth

The fickle, ever-changing whims of unified builds shuffled code around enough that the place where we are printing this value inlined this function and complained about the unique_ptr being null. We continue to not care about this output, so instead of messing around with copying the characters we just return an empty string.

Pushed by iireland@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/969dfa0cd82e
Fix v8::Address / js::jit::Address confusion r=lth
https://hg.mozilla.org/integration/autoland/rev/777fe18afe35
Fix ToCString r=mgaudet
Flags: needinfo?(iireland)
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
You need to log in before you can comment on or make changes to this bug.