Closed Bug 1643727 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24013 - When a function named 'getPointAtLength' is called with non-rendered, throw exception

Categories

(Core :: SVG, task, P4)

Product:
Core
Component:
SVG
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla80
Tracking Flags:
Tracking Status
firefox80 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24013 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24013
Details from upstream follow.

Hyunjune <hyunjune.kim@samsung.com> wrote:

When a function named 'getPointAtLength' is called with non-rendered, throw exception

getPointAtLength[1] on SVGGeometryElement should throw InvalidStateError
for non-rendered elements, so this patch throws InvalidStateError if there is not
LayoutObject on the target element.

[1] https://svgwg.org/svg2-draft/types.html#__svg__SVGGeometryElement__getPointAtLength

Bug: 972979
Change-Id: I26eb5330127ebbca9fbf55d796ce8159a09bfcb4
Reviewed-on: https://chromium-review.googlesource.com/2147168
WPT-Export-Revision: 870fc0eae39b704ac2b0961bd521c24aa64ad796

Component: web-platform-tests → SVG
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
PASS: 13
FAIL: 15

Chrome

OK : 4
PASS: 8
FAIL: 20

Safari

OK : 4
PASS: 15
FAIL: 13

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/svg/types/scripted/SVGGeometryElement.getPointAtLength-05.svg
SVGGeometryElement.getPointAtLength: 'display' and empty path, circle with display: none and an empty path: FAIL (Chrome: FAIL, Safari: PASS)
SVGGeometryElement.getPointAtLength: 'display' and empty path, rect with display: defualt and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
SVGGeometryElement.getPointAtLength: 'display' and empty path, polyline with display: none and an empty path: FAIL (Chrome: FAIL, Safari: PASS)
SVGGeometryElement.getPointAtLength: 'display' and empty path, ellipse with display: none and an empty path: FAIL (Chrome: FAIL, Safari: PASS)
SVGGeometryElement.getPointAtLength: 'display' and empty path, ellipse with display: default and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
SVGGeometryElement.getPointAtLength: 'display' and empty path, rect with display: none and an empty path: FAIL (Chrome: FAIL, Safari: PASS)
SVGGeometryElement.getPointAtLength: 'display' and empty path, path with display: none and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
SVGGeometryElement.getPointAtLength: 'display' and empty path, path with display: defualt and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
SVGGeometryElement.getPointAtLength: 'display' and empty path, polygon with display: none and an empty path: FAIL (Chrome: FAIL, Safari: PASS)
SVGGeometryElement.getPointAtLength: 'display' and empty path, polyline with display: default and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
SVGGeometryElement.getPointAtLength: 'display' and empty path, circle with display: default and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
SVGGeometryElement.getPointAtLength: 'display' and empty path, polygon with display: defualt and an empty path: FAIL (Chrome: FAIL, Safari: FAIL)
/svg/types/scripted/SVGGeometryElement.getPointAtLength-03.svg
When SVGGeometryElement.getPointAtLength is called with an element that is not in the document, throw exception with SVGRectElement: FAIL (Chrome: FAIL, Safari: PASS)
When SVGGeometryElement.getPointAtLength is called with an element that is not in the document, throw exception with SVGPathElement: FAIL (Chrome: FAIL, Safari: FAIL)
When SVGGeometryElement.getPointAtLength is called with an element that is not in the document, throw exception with SVGCircleElement: FAIL (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0da72504b28
[wpt PR 24013] - When SVGGeometryElement.getPointAtLength is called with with non-rendered, throw exception, a=testonly
https://hg.mozilla.org/integration/autoland/rev/5fe0c3aa9f94
[wpt PR 24013] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a0da72504b28
https://hg.mozilla.org/mozilla-central/rev/5fe0c3aa9f94

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox80: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.