1643747 - Setting RUST_LOG=crate=debug on android will emit debug logs for all crates

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Do an android build, and run e.g. ./mach mochitest --setenv RUST_LOG=webrender=debug --enable-webrender --keep-open=false gfx/layers/apz/test/mochitest/test_group_touchevents-3.html. In another terminal, watch adb logcat (or pipe it to a file or whatever)

Expected:
Debug-level logs from webrender are emitted to logcat, but not from other modules

Actual:
All sorts of debug-level logs show up, notably from stylo (e.g. style::invalidation::stylesheets or style::stylist tags).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

I suspect that this is because the log_out implementation on android here doesn't do any checks and bypasses the checks that env_logger does on non-Android.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1643747 - Filter rust logging on android by the underlying env_logger's filters. r?froydnj

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6adfcf57b6cb
Filter rust logging on android by the underlying env_logger's filters. r=froydnj

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6adfcf57b6cb