Land strings for What's New Panel content in Firefox 78
Categories
(Firefox :: Messaging System, enhancement)
Tracking
()
People
(Reporter: andreio, Assigned: andreio)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
Assignee | ||
Comment 1•4 years ago
|
||
Pushed by aoprea@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42e5fd73799f Land strings for What's New Panel content in Firefox 78 r=flod,fluent-reviewers
Comment 3•4 years ago
|
||
bugherder |
Assignee | ||
Comment 4•4 years ago
|
||
Comment on attachment 9154627 [details]
Bug 1643758 - Land strings for What's New Panel content in Firefox 78
Beta/Release Uplift Approval Request
- User impact if declined: We ship these messages via remote-settings, but want the strings in the build as fallback. These uplifts have approval from l10n (flod)
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Fallback strings for remote messages, no actual code
- String changes made/needed:
Comment 5•4 years ago
|
||
(In reply to Andrei Oprea [:andreio] from comment #4)
- String changes made/needed:
Note: there are string changes in the patch, and they're OK to uplift (sheriff will still need the l10n=XXX
in the commit message).
Comment 6•4 years ago
|
||
Comment on attachment 9154627 [details]
Bug 1643758 - Land strings for What's New Panel content in Firefox 78
approved for 78.0b5
Comment 7•4 years ago
|
||
bugherder uplift |
Comment 8•4 years ago
|
||
I have verified that the "Protections at a glance" and the "Better PDF experience" messages are successfully displayed in the "What's New" panel and are respecting the specifications from here.
Verified using the latest Firefox Beta (78.0b9 Build ID - 20200619002543 en-US) and the latest Firefox Nightly (79.0a1 Build ID - 20200621093846 en-US) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.
Description
•